BUG: Bug in DatetimeIndex iteration, related to (GH8890), fixed in (GH9100)

Author: jreback

doc/source/whatsnew/v0.16.0.txt

@@ -51,3 +51,4 @@ Bug Fixes
 
 - Fixed compatibility issue in ``DatetimeIndex`` affecting architectures where ``numpy.int_`` defaults to ``numpy.int32`` (:issue:`8943`)
 - Bug in ``MultiIndex.has_duplicates`` when having many levels causes an indexer overflow (:issue:`9075`)
+- Bug in DatetimeIndex iteration, related to (:issue:`8890`), fixed in (:issue:`9100`)

pandas/tseries/tests/test_timeseries.py

@@ -2332,8 +2332,18 @@ def test_iteration_preserves_tz(self):
         for i, ts in enumerate(index):
             result = ts
             expected = index[i]
+            self.assertEqual(result._repr_base, expected._repr_base)
             self.assertEqual(result, expected)
 
+        # 9100
+        index = pd.DatetimeIndex(['2014-12-01 03:32:39.987000-08:00','2014-12-01 04:12:34.987000-08:00'])
+        for i, ts in enumerate(index):
+            result = ts
+            expected = index[i]
+            self.assertEqual(result._repr_base, expected._repr_base)
+            self.assertEqual(result, expected)
+
+
     def test_misc_coverage(self):
         rng = date_range('1/1/2000', periods=5)
         result = rng.groupby(rng.day)

pandas/tslib.pyx

@@ -128,9 +128,10 @@ def ints_to_pydatetime(ndarray[int64_t] arr, tz=None, offset=None, box=False):
                     result[i] = NaT
                 else:
                     pandas_datetime_to_datetimestruct(value, PANDAS_FR_ns, &dts)
-                    dt = func_create(value, dts, tz, offset)
-                    if not box:
-                        dt = dt + tz.utcoffset(dt)
+                    dt = create_datetime_from_ts(value, dts, tz, offset)
+                    dt = dt + tz.utcoffset(dt)
+                    if box:
+                        dt = Timestamp(dt)
                     result[i] = dt
         else:
             trans, deltas, typ = _get_dst_info(tz)