test coverage

Author: wesm

pandas/core/panel.py

@@ -207,7 +207,7 @@ def __init__(self, data, items=None, major_axis=None, minor_axis=None,
             elif dtype is not None:
                 # no choice but to copy
                 mgr = mgr.cast(dtype)
-        elif isinstance(data, np.ndarray):
+        elif isinstance(data, (np.ndarray, list)):
             mgr = self._init_matrix(data, [items, major_axis, minor_axis],
                                     dtype=dtype, copy=copy)
         else: # pragma: no cover
@@ -376,7 +376,7 @@ def __setstate__(self, state):
             self._data = state
         elif len(state) == 4: # pragma: no cover
             self._unpickle_panel_compat(state)
-        else:
+        else: # pragma: no cover
             raise ValueError('unrecognized pickle')
 
     def _unpickle_panel_compat(self, state): # pragma: no cover
@@ -550,10 +550,6 @@ def fillna(self, value=None, method='pad'):
 
             return WidePanel.from_dict(result)
         else:
-            # Float type values
-            if len(self.items) == 0:
-                return self
-
             new_data = self._data.fillna(value)
             return WidePanel(new_data)
 

pandas/tests/test_panel.py

@@ -334,6 +334,21 @@ def test_constructor(self):
         self.assert_(wp._data is not self.panel._data)
         assert_panel_equal(wp, self.panel)
 
+        # strings handled prop
+        wp = WidePanel([[['foo', 'foo', 'foo',],
+                         ['foo', 'foo', 'foo']]])
+        self.assert_(wp.values.dtype == np.object_)
+
+        vals = self.panel.values
+
+        # no copy
+        wp = WidePanel(vals)
+        self.assert_(wp.values is vals)
+
+        # copy
+        wp = WidePanel(vals, copy=True)
+        self.assert_(wp.values is not vals)
+
     def test_constructor_cast(self):
         casted = WidePanel(self.panel._data, dtype=int)
         casted2 = WidePanel(self.panel.values, dtype=int)
@@ -443,6 +458,15 @@ def test_setitem(self):
         self.panel['ItemG'] = 1
         self.panel['ItemE'] = 1
 
+        # object dtype
+        self.panel['ItemQ'] = 'foo'
+        self.assert_(self.panel['ItemQ'].values.dtype == np.object_)
+
+        # boolean dtype
+        self.panel['ItemP'] = self.panel['ItemA'] > 0
+        self.assert_(self.panel['ItemP'].values.dtype == np.bool_)
+
+
     def test_conform(self):
         df = self.panel['ItemA'][:-5].filter(items=['A', 'B'])
         conformed = self.panel.conform(df)
@@ -507,6 +531,10 @@ def test_fillna(self):
         assert_frame_equal(filled['ItemA'],
                            self.panel['ItemA'].fillna(method='backfill'))
 
+        empty = self.panel.reindex(items=[])
+        filled = empty.fillna(0)
+        assert_panel_equal(filled, empty)
+
     def test_combinePanel_with_long(self):
         lng = self.panel.to_long(filter_observations=False)
         result = self.panel.add(lng)