TYP: Enable pyright's reportInconsistentConstructor (#54398)

* Enable pyright's reportInconsistentConstructor

* bump pyright without adding new errors

Author: twoertwein

.pre-commit-config.yaml

@@ -138,7 +138,7 @@ repos:
         types: [python]
         stages: [manual]
         additional_dependencies: &pyright_dependencies
-        - [email protected].296
+        - [email protected].305
     -   id: pyright
         # note: assumes python env is setup and activated
         name: pyright reportGeneralTypeIssues

pandas/_typing.py

@@ -463,3 +463,6 @@ def closed(self) -> bool:
 
 # to_stata
 ToStataByteorder = Literal[">", "<", "little", "big"]
+
+# ExcelWriter
+ExcelWriterIfSheetExists = Literal["error", "new", "replace", "overlay"]

pandas/core/computation/ops.py

@@ -189,9 +189,6 @@ def ndim(self) -> int:
 
 
 class Constant(Term):
-    def __init__(self, value, env, side=None, encoding=None) -> None:
-        super().__init__(value, env, side=side, encoding=encoding)
-
     def _resolve_name(self):
         return self._name
 

pandas/core/computation/pytables.py

@@ -93,9 +93,9 @@ def value(self):
 
 
 class Constant(Term):
-    def __init__(self, value, env: PyTablesScope, side=None, encoding=None) -> None:
+    def __init__(self, name, env: PyTablesScope, side=None, encoding=None) -> None:
         assert isinstance(env, PyTablesScope), type(env)
-        super().__init__(value, env, side=side, encoding=encoding)
+        super().__init__(name, env, side=side, encoding=encoding)
 
     def _resolve_name(self):
         return self._name

pandas/core/indexes/accessors.py

@@ -573,7 +573,7 @@ class PeriodProperties(Properties):
 class CombinedDatetimelikeProperties(
     DatetimeProperties, TimedeltaProperties, PeriodProperties
 ):
-    def __new__(cls, data: Series):
+    def __new__(cls, data: Series):  # pyright: ignore[reportInconsistentConstructor]
         # CombinedDatetimelikeProperties isn't really instantiated. Instead
         # we need to choose which parent (datetime or timedelta) is
         # appropriate. Since we're checking the dtypes anyway, we'll just

pandas/io/excel/_base.py

@@ -74,6 +74,7 @@
     from pandas._typing import (
         DtypeArg,
         DtypeBackend,
+        ExcelWriterIfSheetExists,
         FilePath,
         IntStrT,
         ReadBuffer,
@@ -1129,7 +1130,7 @@ def __new__(
         datetime_format: str | None = None,
         mode: str = "w",
         storage_options: StorageOptions | None = None,
-        if_sheet_exists: Literal["error", "new", "replace", "overlay"] | None = None,
+        if_sheet_exists: ExcelWriterIfSheetExists | None = None,
         engine_kwargs: dict | None = None,
     ) -> ExcelWriter:
         # only switch class if generic(ExcelWriter)
@@ -1218,7 +1219,7 @@ def __init__(
         datetime_format: str | None = None,
         mode: str = "w",
         storage_options: StorageOptions | None = None,
-        if_sheet_exists: str | None = None,
+        if_sheet_exists: ExcelWriterIfSheetExists | None = None,
         engine_kwargs: dict[str, Any] | None = None,
     ) -> None:
         # validate that this engine can handle the extension

pandas/io/excel/_odswriter.py

@@ -19,6 +19,7 @@
 
 if TYPE_CHECKING:
     from pandas._typing import (
+        ExcelWriterIfSheetExists,
         FilePath,
         StorageOptions,
         WriteExcelBuffer,
@@ -39,7 +40,7 @@ def __init__(
         datetime_format=None,
         mode: str = "w",
         storage_options: StorageOptions | None = None,
-        if_sheet_exists: str | None = None,
+        if_sheet_exists: ExcelWriterIfSheetExists | None = None,
         engine_kwargs: dict[str, Any] | None = None,
         **kwargs,
     ) -> None:

pandas/io/excel/_openpyxl.py

@@ -28,6 +28,7 @@
     from openpyxl.workbook import Workbook
 
     from pandas._typing import (
+        ExcelWriterIfSheetExists,
         FilePath,
         ReadBuffer,
         Scalar,
@@ -48,7 +49,7 @@ def __init__(
         datetime_format: str | None = None,
         mode: str = "w",
         storage_options: StorageOptions | None = None,
-        if_sheet_exists: str | None = None,
+        if_sheet_exists: ExcelWriterIfSheetExists | None = None,
         engine_kwargs: dict[str, Any] | None = None,
         **kwargs,
     ) -> None:

pandas/io/excel/_xlsxwriter.py

@@ -15,6 +15,7 @@
 
 if TYPE_CHECKING:
     from pandas._typing import (
+        ExcelWriterIfSheetExists,
         FilePath,
         StorageOptions,
         WriteExcelBuffer,
@@ -189,7 +190,7 @@ def __init__(
         datetime_format: str | None = None,
         mode: str = "w",
         storage_options: StorageOptions | None = None,
-        if_sheet_exists: str | None = None,
+        if_sheet_exists: ExcelWriterIfSheetExists | None = None,
         engine_kwargs: dict[str, Any] | None = None,
         **kwargs,
     ) -> None:

pyproject.toml

@@ -732,6 +732,7 @@ include = ["pandas", "typings"]
 exclude = ["pandas/tests", "pandas/io/clipboard", "pandas/util/version"]
 # enable subset of "strict"
 reportDuplicateImport = true
+reportInconsistentConstructor = true
 reportInvalidStubStatement = true
 reportOverlappingOverload = true
 reportPropertyTypeMismatch = true

pyright_reportGeneralTypeIssues.json

@@ -1,4 +1,3 @@
-# this becomes obsolete when reportGeneralTypeIssues can be enabled in pyproject.toml
 {
     "typeCheckingMode": "off",
     "reportGeneralTypeIssues": true,
@@ -9,12 +8,11 @@
       ],
     "exclude":
       [
-        # exclude tests
         "pandas/tests",
-        # exclude vendored files
+
         "pandas/io/clipboard",
         "pandas/util/version",
-        # and all files that currently don't pass
+
         "pandas/_testing/__init__.py",
         "pandas/_testing/_hypothesis.py",
         "pandas/_testing/_io.py",