Skip to content

Commit 846cff9

Browse files
mroeschkeMatt Roeschke
and
Matt Roeschke
authored
REF: Remove rolling window fixed algorithms (#36567)
* Fix rolling test result, removed fixed algorithms, some rolling apply with center tests still failing * Rename function and move offset to correct location * Impliment center in terms of indexers * Get all the tests to pass * Remove center from _apply as no longer needed * Add better typing * Deal with numeric precision * Remove code related to center now being implimented in the fixed indexer * Add note regarding precision issues * Note performance hit * Remove tilde * Change useage of get_cython_func_type * Remove self.center from count's _apply Co-authored-by: Matt Roeschke <[email protected]>
1 parent 31ae9a5 commit 846cff9

File tree

6 files changed

+84
-494
lines changed

6 files changed

+84
-494
lines changed

doc/source/whatsnew/v1.2.0.rst

+1
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,7 @@ Performance improvements
310310
- The internal index method :meth:`~Index._shallow_copy` now makes the new index and original index share cached attributes,
311311
avoiding creating these again, if created on either. This can speed up operations that depend on creating copies of existing indexes (:issue:`36840`)
312312
- Performance improvement in :meth:`RollingGroupby.count` (:issue:`35625`)
313+
- Small performance decrease to :meth:`Rolling.min` and :meth:`Rolling.max` for fixed windows (:issue:`36567`)
313314

314315
.. ---------------------------------------------------------------------------
315316

0 commit comments

Comments
 (0)