Skip to content

Commit 81da44b

Browse files
rbenesradekbenesinno
authored andcommitted
Use default true. Be silent if unsupported pytables
1 parent 4daff82 commit 81da44b

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

pandas/io/pytables.py

+3-7
Original file line numberDiff line numberDiff line change
@@ -984,7 +984,7 @@ def put(
984984
data_columns: Optional[List[str]] = None,
985985
encoding=None,
986986
errors: str = "strict",
987-
track_times: Optional[bool] = None,
987+
track_times: bool = True,
988988
):
989989
"""
990990
Store object in HDFStore.
@@ -1630,7 +1630,7 @@ def _write_to_group(
16301630
data_columns=None,
16311631
encoding=None,
16321632
errors: str = "strict",
1633-
track_times: Optional[bool] = None,
1633+
track_times: bool = True,
16341634
):
16351635
group = self.get_node(key)
16361636

@@ -4113,7 +4113,7 @@ def write(
41134113
dropna=False,
41144114
nan_rep=None,
41154115
data_columns=None,
4116-
track_times=None,
4116+
track_times=True,
41174117
):
41184118

41194119
if not append and self.is_exists:
@@ -4151,10 +4151,6 @@ def write(
41514151

41524152
if LooseVersion(tables_version) >= LooseVersion("3.4.3"):
41534153
options["track_times"] = track_times
4154-
else:
4155-
raise ValueError(
4156-
"You cannot set track_times with table version < 3.4.3"
4157-
)
41584154

41594155
# create the table
41604156
table._handle.create_table(table.group, **options)

pandas/tests/io/pytables/test_store.py

+1-7
Original file line numberDiff line numberDiff line change
@@ -328,13 +328,7 @@ def create_h5_and_return_checksum(track_times):
328328

329329
return checksum(path)
330330

331-
if LooseVersion(tables.__version__) < LooseVersion("3.4.3"):
332-
with pytest.raises(
333-
ValueError,
334-
match="You cannot set track_times with table version < 3.4.3",
335-
):
336-
create_h5_and_return_checksum(track_times=False)
337-
else:
331+
if LooseVersion(tables.__version__) >= LooseVersion("3.4.3"):
338332
checksum_0_tt_false = create_h5_and_return_checksum(track_times=False)
339333
checksum_0_tt_true = create_h5_and_return_checksum(track_times=True)
340334

0 commit comments

Comments
 (0)