Skip to content

Commit 7fdd03e

Browse files
committed
Take out comment and use product
1 parent 6bd6ddd commit 7fdd03e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pandas/_libs/lib.pyx

-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ def memory_usage_of_objects(ndarray[object, ndim=1] arr):
6767
cdef int64_t s = 0
6868

6969
n = len(arr)
70-
# Hrm why was this 0 <= i < n
7170
for i from 0 < i < n:
7271
s += arr[i].__sizeof__()
7372
return s

pandas/tests/sparse/series/test_series.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
from pandas.core.sparse.api import SparseSeries
2424
from pandas.tests.series.test_api import SharedWithSparse
2525

26+
from itertools import product
2627

2728
def _test_data1():
2829
# nan-based
@@ -974,8 +975,8 @@ def test_combine_first(self):
974975
@pytest.mark.parametrize('deep,fill_values', [([True, False],
975976
[0, 1, np.nan, None])])
976977
def test_memory_usage_deep(self, deep, fill_values):
977-
for fv in fill_values:
978-
sparse_series = SparseSeries(fill_values, fill_value=fv)
978+
for deep, fill_value in product(deep, fill_values):
979+
sparse_series = SparseSeries(fill_values, fill_value=fill_value)
979980
dense_series = Series(fill_values)
980981
sparse_usage = sparse_series.memory_usage(deep=deep)
981982
dense_usage = dense_series.memory_usage(deep=deep)

0 commit comments

Comments
 (0)