Skip to content

Commit 7f9fc44

Browse files
author
Mateusz Górski
committed
Added issue number to test and changed comment in equals() function
1 parent 909200c commit 7f9fc44

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pandas/core/internals/managers.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1394,8 +1394,8 @@ def equals(self, other):
13941394
if len(self.blocks) != len(other.blocks):
13951395
return False
13961396

1397-
# canonicalize block order, using a tuple combining the type
1398-
# name and then mgr_locs because there might be unconsolidated
1397+
# canonicalize block order, using a tuple combining the mgr_locs
1398+
# then type name because there might be unconsolidated
13991399
# blocks (say, Categorical) which can only be distinguished by
14001400
# the iteration order
14011401
def canonicalize(block):

pandas/tests/internals/test_internals.py

+1
Original file line numberDiff line numberDiff line change
@@ -1300,6 +1300,7 @@ def test_make_block_no_pandas_array():
13001300

13011301

13021302
def test_dataframe_not_equal():
1303+
# see GH28839
13031304
df1 = pd.DataFrame({"a": [1, 2], "b": ["s", "d"]})
13041305
df2 = pd.DataFrame({"a": ["s", "d"], "b": [1, 2]})
13051306
assert df1.equals(df2) is False

0 commit comments

Comments
 (0)