CI: Versioneer not picking up version in 32-bit build

Author: lithomas1

.github/workflows/32-bit-linux.yml

@@ -23,9 +23,15 @@ jobs:
 
       - name: Run 32-bit manylinux2014 Docker Build / Tests
         run: |
+          # Without this (line 34), versioneer will not be able to determine the pandas version.
+          # This is because of a security update to git that blocks it from reading the config folder if
+          # it is not owned by the current user. We hit this since the "mounted" folder is not hit by the
+          # Docker container. 
+          # xref https://github.com/pypa/manylinux/issues/1309
           docker pull quay.io/pypa/manylinux2014_i686
           docker run --platform linux/386 -v $(pwd):/pandas quay.io/pypa/manylinux2014_i686 \
           /bin/bash -xc "cd pandas && \
+          git config --global --add safe.directory /pandas && \
           /opt/python/cp38-cp38/bin/python -m venv ~/virtualenvs/pandas-dev && \
           . ~/virtualenvs/pandas-dev/bin/activate && \
           python -m pip install --no-deps -U pip wheel 'setuptools<60.0.0' && \

pandas/tests/test_common.py

@@ -5,11 +5,6 @@
 import numpy as np
 import pytest
 
-from pandas.compat import (
-    IS64,
-    is_ci_environment,
-)
-
 import pandas as pd
 from pandas import Series
 import pandas._testing as tm
@@ -162,9 +157,6 @@ def test_standardize_mapping():
     assert isinstance(com.standardize_mapping(dd), partial)
 
 
-@pytest.mark.xfail(
-    is_ci_environment() and not IS64, reason="Failing on 32 bit Python CI job"
-)
 def test_git_version():
     # GH 21295
     git_version = pd.__git_version__

pandas/tests/util/test_show_versions.py

@@ -4,10 +4,6 @@
 
 import pytest
 
-from pandas.compat import (
-    IS64,
-    is_ci_environment,
-)
 from pandas.util._print_versions import (
     _get_dependency_info,
     _get_sys_info,
@@ -73,9 +69,6 @@ def test_show_versions_console_json(capsys):
     assert result == expected
 
 
-@pytest.mark.xfail(
-    is_ci_environment() and not IS64, reason="Failing on 32 bit Python CI job"
-)
 def test_show_versions_console(capsys):
     # gh-32041
     # gh-32041

versioneer.py

@@ -649,7 +649,7 @@ def git_pieces_from_vcs(tag_prefix, root, verbose, run_command=run_command):
         GITS = ["git.cmd", "git.exe"]
 
     out, rc = run_command(GITS, ["rev-parse", "--git-dir"], cwd=root,
-                          hide_stderr=True)
+                          hide_stderr=False)
     if rc != 0:
         if verbose:
             print("Directory %%s not under git control" %% root)
@@ -1054,7 +1054,7 @@ def git_pieces_from_vcs(tag_prefix, root, verbose, run_command=run_command):
     if sys.platform == "win32":
         GITS = ["git.cmd", "git.exe"]
 
-    out, rc = run_command(GITS, ["rev-parse", "--git-dir"], cwd=root, hide_stderr=True)
+    out, rc = run_command(GITS, ["rev-parse", "--git-dir"], cwd=root, hide_stderr=False)
     if rc != 0:
         if verbose:
             print("Directory %s not under git control" % root)