Skip to content

Commit 7bdeae1

Browse files
committed
Merge pull request #6261 from bwignall/assert_6175_4
CLN: More work on converting assert_'s to specialized forms
2 parents ad26bb5 + f9cac07 commit 7bdeae1

File tree

6 files changed

+178
-177
lines changed

6 files changed

+178
-177
lines changed

pandas/tests/test_common.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -803,7 +803,7 @@ def test_1d_bool(self):
803803
self.assert_(np.array_equal(result, expected))
804804

805805
result = com.take_1d(arr, [0, 2, -1])
806-
self.assert_(result.dtype == np.object_)
806+
self.assertEqual(result.dtype, np.object_)
807807

808808
def test_2d_bool(self):
809809
arr = np.array([[0, 1, 0],
@@ -819,7 +819,7 @@ def test_2d_bool(self):
819819
self.assert_(np.array_equal(result, expected))
820820

821821
result = com.take_nd(arr, [0, 2, -1])
822-
self.assert_(result.dtype == np.object_)
822+
self.assertEqual(result.dtype, np.object_)
823823

824824
def test_2d_float32(self):
825825
arr = np.random.randn(4, 3).astype(np.float32)

pandas/tests/test_expressions.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -238,19 +238,19 @@ def test_invalid(self):
238238

239239
# no op
240240
result = expr._can_use_numexpr(operator.add, None, self.frame, self.frame, 'evaluate')
241-
self.assert_(result == False)
241+
self.assertFalse(result)
242242

243243
# mixed
244244
result = expr._can_use_numexpr(operator.add, '+', self.mixed, self.frame, 'evaluate')
245-
self.assert_(result == False)
245+
self.assertFalse(result)
246246

247247
# min elements
248248
result = expr._can_use_numexpr(operator.add, '+', self.frame2, self.frame2, 'evaluate')
249-
self.assert_(result == False)
249+
self.assertFalse(result)
250250

251251
# ok, we only check on first part of expression
252252
result = expr._can_use_numexpr(operator.add, '+', self.frame, self.frame2, 'evaluate')
253-
self.assert_(result == True)
253+
self.assertTrue(result)
254254

255255
def test_binary_ops(self):
256256

@@ -265,14 +265,14 @@ def testit():
265265
op = getattr(operator, op, None)
266266
if op is not None:
267267
result = expr._can_use_numexpr(op, op_str, f, f, 'evaluate')
268-
self.assert_(result == (not f._is_mixed_type))
268+
self.assertNotEqual(result, f._is_mixed_type)
269269

270270
result = expr.evaluate(op, op_str, f, f, use_numexpr=True)
271271
expected = expr.evaluate(op, op_str, f, f, use_numexpr=False)
272272
assert_array_equal(result,expected.values)
273273

274274
result = expr._can_use_numexpr(op, op_str, f2, f2, 'evaluate')
275-
self.assert_(result == False)
275+
self.assertFalse(result)
276276

277277

278278
expr.set_use_numexpr(False)
@@ -300,14 +300,14 @@ def testit():
300300
op = getattr(operator,op)
301301

302302
result = expr._can_use_numexpr(op, op_str, f11, f12, 'evaluate')
303-
self.assert_(result == (not f11._is_mixed_type))
303+
self.assertNotEqual(result, f11._is_mixed_type)
304304

305305
result = expr.evaluate(op, op_str, f11, f12, use_numexpr=True)
306306
expected = expr.evaluate(op, op_str, f11, f12, use_numexpr=False)
307307
assert_array_equal(result,expected.values)
308308

309309
result = expr._can_use_numexpr(op, op_str, f21, f22, 'evaluate')
310-
self.assert_(result == False)
310+
self.assertFalse(result)
311311

312312
expr.set_use_numexpr(False)
313313
testit()

pandas/tests/test_format.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ def test_to_string_repr_unicode(self):
290290
except:
291291
pass
292292
if not line.startswith('dtype:'):
293-
self.assert_(len(line) == line_len)
293+
self.assertEqual(len(line), line_len)
294294

295295
# it works even if sys.stdin in None
296296
_stdin= sys.stdin
@@ -731,7 +731,7 @@ def test_nonunicode_nonascii_alignment(self):
731731
df = DataFrame([["aa\xc3\xa4\xc3\xa4", 1], ["bbbb", 2]])
732732
rep_str = df.to_string()
733733
lines = rep_str.split('\n')
734-
self.assert_(len(lines[1]) == len(lines[2]))
734+
self.assertEqual(len(lines[1]), len(lines[2]))
735735

736736
def test_unicode_problem_decoding_as_ascii(self):
737737
dm = DataFrame({u('c/\u03c3'): Series({'test': np.NaN})})
@@ -915,7 +915,7 @@ def test_long_series(self):
915915
import re
916916
str_rep = str(s)
917917
nmatches = len(re.findall('dtype',str_rep))
918-
self.assert_(nmatches == 1)
918+
self.assertEqual(nmatches, 1)
919919

920920
def test_index_with_nan(self):
921921
# GH 2850

0 commit comments

Comments
 (0)