CLN: Consistent imports - linting rules (#29318)

Author: SaturnFromTitan

ci/code_checks.sh

@@ -120,9 +120,15 @@ if [[ -z "$CHECK" || "$CHECK" == "patterns" ]]; then
     # Check for imports from pandas.core.common instead of `import pandas.core.common as com`
     # Check for imports from collections.abc instead of `from collections import abc`
     MSG='Check for non-standard imports' ; echo $MSG
-    invgrep -R --include="*.py*" -E "from pandas.core.common import " pandas
-    invgrep -R --include="*.py*" -E "from collections.abc import " pandas
-    invgrep -R --include="*.py*" -E "from numpy import nan " pandas
+    invgrep -R --include="*.py*" -E "from pandas.core.common import" pandas
+    invgrep -R --include="*.py*" -E "from pandas.core import common" pandas
+    invgrep -R --include="*.py*" -E "from collections.abc import" pandas
+    invgrep -R --include="*.py*" -E "from numpy import nan" pandas
+
+    # Checks for test suite
+    # Check for imports from pandas.util.testing instead of `import pandas.util.testing as tm`
+    invgrep -R --include="*.py*" -E "from pandas.util.testing import" pandas/tests
+    invgrep -R --include="*.py*" -E "from pandas.util import testing as tm" pandas/tests
     RET=$(($RET + $?)) ; echo $MSG "DONE"
 
     MSG='Check for use of exec' ; echo $MSG

pandas/core/algorithms.py

@@ -46,7 +46,7 @@
 from pandas.core.dtypes.generic import ABCIndex, ABCIndexClass, ABCSeries
 from pandas.core.dtypes.missing import isna, na_value_for_dtype
 
-from pandas.core import common as com
+import pandas.core.common as com
 from pandas.core.construction import array, extract_array
 from pandas.core.indexers import validate_indices
 

pandas/core/computation/expr.py

@@ -12,7 +12,7 @@
 import numpy as np
 
 import pandas as pd
-from pandas.core import common as com
+import pandas.core.common as com
 from pandas.core.computation.common import (
     _BACKTICK_QUOTED_STRING,
     _remove_spaces_column_name,

pandas/core/indexes/period.py

@@ -20,11 +20,11 @@
     pandas_dtype,
 )
 
-from pandas.core import common as com
 from pandas.core.accessor import delegate_names
 from pandas.core.algorithms import unique1d
 from pandas.core.arrays.period import PeriodArray, period_array, validate_dtype_freq
 from pandas.core.base import _shared_docs
+import pandas.core.common as com
 import pandas.core.indexes.base as ibase
 from pandas.core.indexes.base import _index_shared_docs, ensure_index
 from pandas.core.indexes.datetimelike import (

pandas/core/reshape/concat.py

@@ -7,11 +7,11 @@
 import numpy as np
 
 from pandas import DataFrame, Index, MultiIndex, Series
-from pandas.core import common as com
 from pandas.core.arrays.categorical import (
     _factorize_from_iterable,
     _factorize_from_iterables,
 )
+import pandas.core.common as com
 from pandas.core.generic import NDFrame
 from pandas.core.index import (
     _all_indexes_same,

pandas/core/reshape/util.py

@@ -2,7 +2,7 @@
 
 from pandas.core.dtypes.common import is_list_like
 
-from pandas.core import common as com
+import pandas.core.common as com
 
 
 def cartesian_product(X):

pandas/tests/indexing/multiindex/test_chaining_and_caching.py

@@ -2,7 +2,7 @@
 import pytest
 
 from pandas import DataFrame, MultiIndex, Series
-from pandas.core import common as com
+import pandas.core.common as com
 import pandas.util.testing as tm
 
 

pandas/tests/indexing/test_chaining_and_caching.py

@@ -3,7 +3,7 @@
 
 import pandas as pd
 from pandas import DataFrame, Series, Timestamp, date_range, option_context
-from pandas.core import common as com
+import pandas.core.common as com
 import pandas.util.testing as tm
 
 

pandas/tests/test_common.py

@@ -8,7 +8,8 @@
 
 import pandas as pd
 from pandas import Series, Timestamp
-from pandas.core import common as com, ops
+from pandas.core import ops
+import pandas.core.common as com
 
 
 def test_get_callable_name():

pandas/tests/test_sorting.py

@@ -6,7 +6,7 @@
 import pytest
 
 from pandas import DataFrame, MultiIndex, Series, array, concat, merge
-from pandas.core import common as com
+import pandas.core.common as com
 from pandas.core.sorting import (
     decons_group_index,
     get_group_index,