added deprecation warning and rolled back to accepting short versions of orient

Author: elmonsomiat

pandas/core/frame.py

@@ -1400,6 +1400,29 @@ def to_dict(self, orient="dict", into=dict):
         # GH16122
         into_c = com.standardize_mapping(into)
         orient = orient.lower()
+        # GH32515
+        if orient not in {"dict", "list", "series", "split", "records", "index"}:
+            warnings.warn(
+                "Using short name for 'orient' is deprecated. Only the "
+                "options: ('dict', list, 'series', 'split', 'records', 'index') "
+                "will be used in a future version. Use one of the above "
+                "to silence this warning.",
+                DeprecationWarning, 
+                stacklevel=2)
+
+        if orient.startswith("d"):
+            orient = "dict"
+        elif orient.startswith("l"):
+            orient = "list"
+        elif orient.startswith("sp"):
+            orient = "split"
+        elif orient.startswith("s"):
+            orient = "series"
+        elif orient.startswith("r"):
+            orient = "records"
+        elif orient.startswith("i"):
+            orient = "index"
+
         if orient == "dict":
             return into_c((k, v.to_dict(into)) for k, v in self.items())
 

pandas/tests/frame/methods/test_to_dict.py

@@ -64,16 +64,22 @@ def test_to_dict_index_not_unique_with_index_orient(self):
         with pytest.raises(ValueError, match=msg):
             df.to_dict(orient="index")
 
-    @pytest.mark.parametrize("orient", ["d", "l", "r", "sp", "s", "i", "xinvalid"])
+    @pytest.mark.parametrize("orient", ["xinvalid"])
     def test_to_dict_invalid_orient(self, orient):
-        # to_dict(orient='d') should fail, as should only take the listed options
-        # see GH#32515
-
         df = DataFrame({"A": [0, 1]})
         msg = f"orient '{orient}' not understood"
         with pytest.raises(ValueError, match=msg):
             df.to_dict(orient=orient)
 
+    @pytest.mark.parametrize("orient", ["d", "l", "r", "sp", "s", "i"])
+    def test_to_dict_short_orient(self, orient):
+        # to_dict(orient='d') or any other short option should raise DeprecationWarning
+        # see GH#32515
+        df = DataFrame({"A": [0, 1]})
+        with pytest.warns(DeprecationWarning):
+            df.to_dict(orient=orient)
+
+
     @pytest.mark.parametrize("mapping", [dict, defaultdict(list), OrderedDict])
     def test_to_dict(self, mapping):
         # orient= should only take the listed options