BUG: sets in str.cat

Author: h-vetinari

doc/source/whatsnew/v0.24.0.txt

@@ -875,7 +875,7 @@ Numeric
 Strings
 ^^^^^^^
 
--
+- Bug in :meth:`Series.str.cat` which falsely did not raise if `others` was a `set` (:issue:`23009`)
 -
 -
 

pandas/core/strings.py

@@ -1996,12 +1996,12 @@ def _get_series_list(self, others, ignore_index=False):
         elif isinstance(others, np.ndarray) and others.ndim == 2:
             others = DataFrame(others, index=idx)
             return ([others[x] for x in others], False)
-        elif is_list_like(others):
+        elif is_list_like(others) and not isinstance(others, set):
             others = list(others)  # ensure iterators do not get read twice etc
 
             # in case of list-like `others`, all elements must be
             # either one-dimensional list-likes or scalars
-            if all(is_list_like(x) for x in others):
+            if all(is_list_like(x) and not isinstance(x, set) for x in others):
                 los = []
                 join_warn = False
                 depr_warn = False

pandas/tests/test_strings.py

@@ -301,7 +301,15 @@ def test_str_cat_mixed_inputs(self, box):
         with tm.assert_raises_regex(TypeError, rgx):
             s.str.cat([u, [u, d]])
 
-        # forbidden input type, e.g. int
+        # forbidden input type: set
+        with tm.assert_raises_regex(TypeError, rgx):
+            s.str.cat(set(u))
+
+        # forbidden input type: set in list
+        with tm.assert_raises_regex(TypeError, rgx):
+            s.str.cat([u, set(u)])
+
+        # other forbidden input type, e.g. int
         with tm.assert_raises_regex(TypeError, rgx):
             s.str.cat(1)