Skip to content

Commit 6f246d5

Browse files
BastiaanBastiaan
Bastiaan
authored and
Bastiaan
committed
Small fixes as requested by jreback, GH12803.
-Moved to group .weekday_name next to .weekday in docs -Added Timestamp test to tseries/tests/test_timeseries.py -Change dtype of weekday_name to np.object_
1 parent 7b14d5c commit 6f246d5

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

doc/source/api.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,7 @@ These can be accessed like ``Series.dt.<property>``.
457457
Series.dt.weekofyear
458458
Series.dt.dayofweek
459459
Series.dt.weekday
460+
Series.dt.weekday_name
460461
Series.dt.dayofyear
461462
Series.dt.quarter
462463
Series.dt.is_month_start
@@ -469,7 +470,6 @@ These can be accessed like ``Series.dt.<property>``.
469470
Series.dt.days_in_month
470471
Series.dt.tz
471472
Series.dt.freq
472-
Series.dt.weekday_name
473473

474474
**Datetime Methods**
475475

@@ -1477,6 +1477,7 @@ Time/Date Components
14771477
DatetimeIndex.week
14781478
DatetimeIndex.dayofweek
14791479
DatetimeIndex.weekday
1480+
DatetimeIndex.weekday_name
14801481
DatetimeIndex.quarter
14811482
DatetimeIndex.tz
14821483
DatetimeIndex.freq
@@ -1488,7 +1489,6 @@ Time/Date Components
14881489
DatetimeIndex.is_year_start
14891490
DatetimeIndex.is_year_end
14901491
DatetimeIndex.inferred_freq
1491-
DatetimeIndex.weekday_name
14921492

14931493
Selecting
14941494
~~~~~~~~~

pandas/tests/series/test_datetime_values.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class TestSeriesDatetimeValues(TestData, tm.TestCase):
2525

2626
def test_dt_namespace_accessor(self):
2727

28-
# GH 7207
28+
# GH 7207, 11128
2929
# test .dt namespace accessor
3030

3131
ok_for_base = ['year', 'month', 'day', 'hour', 'minute', 'second',

pandas/tseries/tests/test_timeseries.py

+8
Original file line numberDiff line numberDiff line change
@@ -3550,6 +3550,14 @@ def test_datetimeindex_accessors(self):
35503550
self.assertEqual(dti.weekday_name[9], u'Saturday')
35513551
self.assertEqual(dti.weekday_name[10], u'Sunday')
35523552

3553+
self.assertEqual(Timestamp('2016-04-04').weekday_name, u'Monday')
3554+
self.assertEqual(Timestamp('2016-04-05').weekday_name, u'Tuesday')
3555+
self.assertEqual(Timestamp('2016-04-06').weekday_name, u'Wednesday')
3556+
self.assertEqual(Timestamp('2016-04-07').weekday_name, u'Thursday')
3557+
self.assertEqual(Timestamp('2016-04-08').weekday_name, u'Friday')
3558+
self.assertEqual(Timestamp('2016-04-09').weekday_name, u'Saturday')
3559+
self.assertEqual(Timestamp('2016-04-10').weekday_name, u'Sunday')
3560+
35533561
self.assertEqual(len(dti.year), 365)
35543562
self.assertEqual(len(dti.month), 365)
35553563
self.assertEqual(len(dti.day), 365)

pandas/tslib.pyx

+1-1
Original file line numberDiff line numberDiff line change
@@ -4411,7 +4411,7 @@ def get_date_name_field(ndarray[int64_t] dtindex, object field):
44114411

44124412
_dayname = np.array(
44134413
['Monday', 'Tuesday', 'Wednesday', 'Thursday', 'Friday', 'Saturday', 'Sunday'],
4414-
dtype=np.str )
4414+
dtype=np.object_ ) # was np.str
44154415

44164416
count = len(dtindex)
44174417
out = np.empty(count, dtype=object)

0 commit comments

Comments
 (0)