Skip to content

Commit 6d5fdbe

Browse files
committed
TST: produce unsorted integer index (consistently with other types)
1 parent 12ac43f commit 6d5fdbe

File tree

3 files changed

+21
-16
lines changed

3 files changed

+21
-16
lines changed

pandas/tests/indexes/test_base.py

+9-7
Original file line numberDiff line numberDiff line change
@@ -830,15 +830,16 @@ def test_map_with_tuples(self):
830830

831831
# Test that returning a single tuple from an Index
832832
# returns an Index.
833-
boolean_index = tm.makeIntIndex(3).map(lambda x: (x,))
834-
expected = Index([(0,), (1,), (2,)])
835-
tm.assert_index_equal(boolean_index, expected)
833+
idx = tm.makeIntIndex(3)
834+
result = tm.makeIntIndex(3).map(lambda x: (x,))
835+
expected = Index([(i,) for i in idx])
836+
tm.assert_index_equal(result, expected)
836837

837838
# Test that returning a tuple from a map of a single index
838839
# returns a MultiIndex object.
839-
boolean_index = tm.makeIntIndex(3).map(lambda x: (x, x == 1))
840-
expected = MultiIndex.from_tuples([(0, False), (1, True), (2, False)])
841-
tm.assert_index_equal(boolean_index, expected)
840+
result = idx.map(lambda x: (x, x == 1))
841+
expected = MultiIndex.from_tuples([(i, i == 1) for i in idx])
842+
tm.assert_index_equal(result, expected)
842843

843844
# Test that returning a single object from a MultiIndex
844845
# returns an Index.
@@ -870,7 +871,8 @@ def test_map_tseries_indices_return_index(self):
870871
def test_map_dictlike(self, mapper):
871872
# GH 12756
872873
expected = Index(['foo', 'bar', 'baz'])
873-
result = tm.makeIntIndex(3).map(mapper(expected.values, [0, 1, 2]))
874+
idx = tm.makeIntIndex(3)
875+
result = idx.map(mapper(expected.values, idx))
874876
tm.assert_index_equal(result, expected)
875877

876878
for name in self.indices.keys():

pandas/tests/indexing/test_floats.py

+9-8
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44

55
from warnings import catch_warnings
66
import numpy as np
7-
from pandas import Series, DataFrame, Index, Float64Index
7+
from pandas import (Series, DataFrame, Index, Float64Index, Int64Index,
8+
RangeIndex)
89
from pandas.util.testing import assert_series_equal, assert_almost_equal
910
import pandas.util.testing as tm
1011

@@ -206,9 +207,9 @@ def test_scalar_integer(self):
206207
# test how scalar float indexers work on int indexes
207208

208209
# integer index
209-
for index in [tm.makeIntIndex, tm.makeRangeIndex]:
210+
for index in [Int64Index, Index]:
210211

211-
i = index(5)
212+
i = index(range(5))
212213
for s in [Series(np.arange(len(i))),
213214
DataFrame(np.random.randn(len(i), len(i)),
214215
index=i, columns=i)]:
@@ -362,9 +363,9 @@ def test_slice_integer(self):
362363
# these coerce to a like integer
363364
# oob indicates if we are out of bounds
364365
# of positional indexing
365-
for index, oob in [(tm.makeIntIndex(5), False),
366-
(tm.makeRangeIndex(5), False),
367-
(tm.makeIntIndex(5) + 10, True)]:
366+
for index, oob in [(Int64Index(range(5)), False),
367+
(RangeIndex(5), False),
368+
(Int64Index(range(5)) + 10, True)]:
368369

369370
# s is an in-range index
370371
s = Series(range(5), index=index)
@@ -486,9 +487,9 @@ def f():
486487
def test_slice_integer_frame_getitem(self):
487488

488489
# similar to above, but on the getitem dim (of a DataFrame)
489-
for index in [tm.makeIntIndex, tm.makeRangeIndex]:
490+
for index in [Int64Index, Index]:
490491

491-
index = index(5)
492+
index = index(range(5))
492493
s = DataFrame(np.random.randn(5, 2), index=index)
493494

494495
def f(idxr):

pandas/util/testing.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -1560,7 +1560,9 @@ def makeBoolIndex(k=10, name=None):
15601560

15611561

15621562
def makeIntIndex(k=10, name=None):
1563-
return Index(lrange(k), name=name)
1563+
if k == 0:
1564+
return Index([], name=name)
1565+
return Index(lrange(1, k) + [0], name=name)
15641566

15651567

15661568
def makeUIntIndex(k=10, name=None):

0 commit comments

Comments
 (0)