Skip to content

Commit 6b06f43

Browse files
authored
API: Rename BaseGrouper.recons_codes to BaseGrouper.reconstructed_codes (#29471)
1 parent c2305d7 commit 6b06f43

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

pandas/core/groupby/generic.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ def value_counts(
655655
rep = partial(np.repeat, repeats=np.add.reduceat(inc, idx))
656656

657657
# multi-index components
658-
codes = self.grouper.recons_codes
658+
codes = self.grouper.reconstructed_codes
659659
codes = [rep(level_codes) for level_codes in codes] + [llab(lab, inc)]
660660
levels = [ping.group_index for ping in self.grouper.groupings] + [lev]
661661
names = self.grouper.names + [self._selection_name]

pandas/core/groupby/ops.py

+11-11
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"""
88

99
import collections
10-
from typing import List, Optional, Sequence, Type
10+
from typing import List, Optional, Sequence, Tuple, Type
1111

1212
import numpy as np
1313

@@ -216,11 +216,11 @@ def indices(self):
216216
return get_indexer_dict(codes_list, keys)
217217

218218
@property
219-
def codes(self):
219+
def codes(self) -> List[np.ndarray]:
220220
return [ping.codes for ping in self.groupings]
221221

222222
@property
223-
def levels(self):
223+
def levels(self) -> List[Index]:
224224
return [ping.group_index for ping in self.groupings]
225225

226226
@property
@@ -264,16 +264,16 @@ def group_info(self):
264264
return comp_ids, obs_group_ids, ngroups
265265

266266
@cache_readonly
267-
def codes_info(self):
267+
def codes_info(self) -> np.ndarray:
268268
# return the codes of items in original grouped axis
269269
codes, _, _ = self.group_info
270270
if self.indexer is not None:
271271
sorter = np.lexsort((codes, self.indexer))
272272
codes = codes[sorter]
273273
return codes
274274

275-
def _get_compressed_codes(self):
276-
all_codes = [ping.codes for ping in self.groupings]
275+
def _get_compressed_codes(self) -> Tuple[np.ndarray, np.ndarray]:
276+
all_codes = self.codes
277277
if len(all_codes) > 1:
278278
group_index = get_group_index(all_codes, self.shape, sort=True, xnull=True)
279279
return compress_group_index(group_index, sort=self.sort)
@@ -286,17 +286,17 @@ def ngroups(self) -> int:
286286
return len(self.result_index)
287287

288288
@property
289-
def recons_codes(self):
289+
def reconstructed_codes(self) -> List[np.ndarray]:
290+
codes = self.codes
290291
comp_ids, obs_ids, _ = self.group_info
291-
codes = (ping.codes for ping in self.groupings)
292292
return decons_obs_group_ids(comp_ids, obs_ids, self.shape, codes, xnull=True)
293293

294294
@cache_readonly
295295
def result_index(self):
296296
if not self.compressed and len(self.groupings) == 1:
297297
return self.groupings[0].result_index.rename(self.names[0])
298298

299-
codes = self.recons_codes
299+
codes = self.reconstructed_codes
300300
levels = [ping.result_index for ping in self.groupings]
301301
result = MultiIndex(
302302
levels=levels, codes=codes, verify_integrity=False, names=self.names
@@ -308,7 +308,7 @@ def get_group_levels(self):
308308
return [self.groupings[0].result_index]
309309

310310
name_list = []
311-
for ping, codes in zip(self.groupings, self.recons_codes):
311+
for ping, codes in zip(self.groupings, self.reconstructed_codes):
312312
codes = ensure_platform_int(codes)
313313
levels = ping.result_index.take(codes)
314314

@@ -768,7 +768,7 @@ def group_info(self):
768768
)
769769

770770
@cache_readonly
771-
def recons_codes(self):
771+
def reconstructed_codes(self) -> List[np.ndarray]:
772772
# get unique result indices, and prepend 0 as groupby starts from the first
773773
return [np.r_[0, np.flatnonzero(self.bins[1:] != self.bins[:-1]) + 1]]
774774

0 commit comments

Comments
 (0)