Skip to content

Commit 6a8055d

Browse files
authored
WARN: sort_values for midx warns unnecessarily if nan is in level (#55386)
1 parent eb6317a commit 6a8055d

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

pandas/core/indexes/multi.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1948,7 +1948,7 @@ def _sort_levels_monotonic(self, raise_if_incomparable: bool = False) -> MultiIn
19481948
# indexer to reorder the level codes
19491949
indexer = ensure_platform_int(indexer)
19501950
ri = lib.get_reverse_indexer(indexer, len(indexer))
1951-
level_codes = algos.take_nd(ri, level_codes)
1951+
level_codes = algos.take_nd(ri, level_codes, fill_value=-1)
19521952

19531953
new_levels.append(lev)
19541954
new_codes.append(level_codes)

pandas/tests/indexes/multi/test_sorting.py

+9
Original file line numberDiff line numberDiff line change
@@ -338,3 +338,12 @@ def test_sort_values_with_na_na_position(dtype, na_position):
338338
]
339339
expected = MultiIndex.from_arrays(arrays)
340340
tm.assert_index_equal(result, expected)
341+
342+
343+
def test_sort_unnecessary_warning():
344+
# GH#55386
345+
midx = MultiIndex.from_tuples([(1.5, 2), (3.5, 3), (0, 1)])
346+
midx = midx.set_levels([2.5, np.nan, 1], level=0)
347+
result = midx.sort_values()
348+
expected = MultiIndex.from_tuples([(1, 3), (2.5, 1), (np.nan, 2)])
349+
tm.assert_index_equal(result, expected)

0 commit comments

Comments
 (0)