mypy-0.730

Author: simonjayhawkins

environment.yml

@@ -22,7 +22,7 @@ dependencies:
   - flake8-comprehensions  # used by flake8, linting of unnecessary comprehensions
   - flake8-rst>=0.6.0,<=0.7.0  # linting of code blocks in rst files
   - isort  # check that imports are in the right order
-  - mypy=0.720
+  - mypy=0.730
   - pycodestyle  # used by flake8
 
   # documentation

pandas/_libs/tslibs/offsets.pyi

@@ -20,12 +20,15 @@ def get_lastbday(year: int, month: int) -> int: ...
 def get_firstbday(year: int, month: int) -> int: ...
 def _get_calendar(weekmask, holidays, calendar): ...
 def _to_dt64(dt, dtype=...): ...
+def _validate_business_time(t_input): ...
 
 # ---------------------------------------------------------------------
 # Constructor Helpers
 
 relativedelta_kwds: Set[str]
 
+def _determine_offset(kwds): ...
+
 # ---------------------------------------------------------------------
 # Mixins & Singletons
 

pandas/compat/pickle_compat.py

@@ -68,7 +68,11 @@ def load_reduce(self):
 
 class _LoadSparseSeries:
     # To load a SparseSeries as a Series[Sparse]
-    def __new__(cls) -> "Series":
+
+    # https://github.com/python/mypy/issues/1020
+    # error: Incompatible return type for "__new__" (returns "Series", but must return
+    # a subtype of "_LoadSparseSeries")
+    def __new__(cls) -> "Series":  # type: ignore
         from pandas import Series
 
         warnings.warn(
@@ -82,7 +86,11 @@ def __new__(cls) -> "Series":
 
 class _LoadSparseFrame:
     # To load a SparseDataFrame as a DataFrame[Sparse]
-    def __new__(cls) -> "DataFrame":
+
+    # https://github.com/python/mypy/issues/1020
+    # error: Incompatible return type for "__new__" (returns "DataFrame", but must
+    # return a subtype of "_LoadSparseFrame")
+    def __new__(cls) -> "DataFrame":  # type: ignore
         from pandas import DataFrame
 
         warnings.warn(
@@ -191,10 +199,10 @@ def __new__(cls) -> "DataFrame":
 
 
 # our Unpickler sub-class to override methods and some dispatcher
-# functions for compat
-
+# functions for compat and uses a non-public class of the pickle module.
 
-class Unpickler(pkl._Unpickler):
+# error: Name 'pkl._Unpickler' is not defined
+class Unpickler(pkl._Unpickler):  # type: ignore
     def find_class(self, module, name):
         # override superclass
         key = (module, name)

pandas/core/indexing.py

@@ -1763,12 +1763,7 @@ def _get_partial_string_timestamp_match_key(self, key, labels):
                         isinstance(component, str)
                         and labels.levels[i]._supports_partial_string_indexing
                     ):
-                        new_key.append(
-                            # https://github.com/python/mypy/issues/2410
-                            # # No overload variant of "slice" matches argument types
-                            # "str", "str", "None"
-                            slice(component, component, None)  # type: ignore
-                        )
+                        new_key.append(slice(component, component, None))
                     else:
                         new_key.append(component)
                 key = tuple(new_key)

pandas/util/_print_versions.py

@@ -5,15 +5,15 @@
 import struct
 import subprocess
 import sys
-from typing import Optional
+from typing import List, Optional, Tuple, Union
 
 from pandas.compat._optional import VERSIONS, _get_version, import_optional_dependency
 
 
-def get_sys_info():
-    "Returns system information as a dict"
+def get_sys_info() -> List[Tuple[str, Optional[Union[str, int]]]]:
+    "Returns system information as a list"
 
-    blob = []
+    blob: List[Tuple[str, Optional[Union[str, int]]]] = []
 
     # get full commit hash
     commit = None
@@ -29,12 +29,7 @@ def get_sys_info():
             pass
         else:
             if pipe.returncode == 0:
-                commit = so
-                try:
-                    commit = so.decode("utf-8")
-                except ValueError:
-                    pass
-                commit = commit.strip().strip('"')
+                commit = so.decode("utf-8").strip().strip('"')
 
     blob.append(("commit", commit))
 

requirements-dev.txt

@@ -9,7 +9,7 @@ flake8
 flake8-comprehensions
 flake8-rst>=0.6.0,<=0.7.0
 isort
-mypy==0.720
+mypy==0.730
 pycodestyle
 gitpython
 sphinx==1.8.5

setup.cfg

@@ -206,6 +206,9 @@ check_untyped_defs=False
 [mypy-pandas.core.indexes.multi]
 check_untyped_defs=False
 
+[mypy-pandas.core.indexes.timedeltas]
+check_untyped_defs=False
+
 [mypy-pandas.core.internals.blocks]
 check_untyped_defs=False