Skip to content

Commit 5fc9976

Browse files
author
Nicholas Ver Halen
committed
Added comments and edited the whatsnew.
1 parent 90eef20 commit 5fc9976

File tree

2 files changed

+20
-19
lines changed

2 files changed

+20
-19
lines changed

doc/source/whatsnew/v0.19.2.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ Bug Fixes
2525

2626
- compat with ``dateutil==2.6.0`` for testing (:issue:`14621`)
2727
- allow ``nanoseconds`` in ``Timestamp.replace`` kwargs (:issue:`14621`)
28-
- Bug in ``pd.to_numeric`` where a 0 was not unsigned on a downcast = 'unsigned' argument (:issue:`14401`)
28+
- Bug in ``pd.to_numeric`` where a 0 was not unsigned on a ``downcast = "unsigned"`` argument (:issue:`14401`)

pandas/tools/tests/test_util.py

+19-18
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
import nose
55

66
import numpy as np
7-
from numpy import (iinfo, int8, int16, int32, int64,
8-
uint8, uint16, uint32,)
7+
from numpy import iinfo
98

109
import pandas as pd
1110
from pandas import (date_range, Index, _np_version_under1p9)
@@ -412,23 +411,25 @@ def test_downcast_limits(self):
412411
i = 'integer'
413412
u = 'unsigned'
414413
dtype_downcast_min_max = [
415-
('int8', i, [iinfo(int8).min, iinfo(int8).max]),
416-
('int16', i, [iinfo(int16).min, iinfo(int16).max]),
417-
('int32', i, [iinfo(int32).min, iinfo(int32).max]),
418-
('int64', i, [iinfo(int64).min, iinfo(int64).max]),
419-
('uint8', u, [iinfo(uint8).min, iinfo(uint8).max]),
420-
('uint16', u, [iinfo(uint16).min, iinfo(uint16).max]),
421-
('uint32', u, [iinfo(uint32).min, iinfo(uint32).max]),
414+
('int8', i, [iinfo(np.int8).min, iinfo(np.int8).max]),
415+
('int16', i, [iinfo(np.int16).min, iinfo(np.int16).max]),
416+
('int32', i, [iinfo(np.int32).min, iinfo(np.int32).max]),
417+
('int64', i, [iinfo(np.int64).min, iinfo(np.int64).max]),
418+
('uint8', u, [iinfo(np.uint8).min, iinfo(np.uint8).max]),
419+
('uint16', u, [iinfo(np.uint16).min, iinfo(np.uint16).max]),
420+
('uint32', u, [iinfo(np.uint32).min, iinfo(np.uint32).max]),
421+
# Test will be skipped until there is more uint64 support.
422422
# ('uint64', u, [iinfo(uint64).min, iinfo(uint64).max]),
423-
('int16', i, [iinfo(int8).min, iinfo(int8).max + 1]),
424-
('int32', i, [iinfo(int16).min, iinfo(int16).max + 1]),
425-
('int64', i, [iinfo(int32).min, iinfo(int32).max + 1]),
426-
('int16', i, [iinfo(int8).min - 1, iinfo(int16).max]),
427-
('int32', i, [iinfo(int16).min - 1, iinfo(int32).max]),
428-
('int64', i, [iinfo(int32).min - 1, iinfo(int64).max]),
429-
('uint16', u, [iinfo(uint8).min, iinfo(uint8).max + 1]),
430-
('uint32', u, [iinfo(uint16).min, iinfo(uint16).max + 1]),
431-
# ('uint64', u, [iinfo(uint32).min, iinfo(uint32).max + 1]),
423+
('int16', i, [iinfo(np.int8).min, iinfo(np.int8).max + 1]),
424+
('int32', i, [iinfo(np.int16).min, iinfo(np.int16).max + 1]),
425+
('int64', i, [iinfo(np.int32).min, iinfo(np.int32).max + 1]),
426+
('int16', i, [iinfo(np.int8).min - 1, iinfo(np.int16).max]),
427+
('int32', i, [iinfo(np.int16).min - 1, iinfo(np.int32).max]),
428+
('int64', i, [iinfo(np.int32).min - 1, iinfo(np.int64).max]),
429+
('uint16', u, [iinfo(np.uint8).min, iinfo(np.uint8).max + 1]),
430+
('uint32', u, [iinfo(np.uint16).min, iinfo(np.uint16).max + 1]),
431+
# Test will be skipped until there is more uint64 support.
432+
# ('uint64', u, [iinfo(np.uint32).min, iinfo(np.uint32).max + 1]),
432433
]
433434

434435
for dtype, downcast, min_max in dtype_downcast_min_max:

0 commit comments

Comments
 (0)