You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: doc/source/development/maintaining.rst
+15-10
Original file line number
Diff line number
Diff line change
@@ -174,6 +174,8 @@ conversation is over. It's typically best to give the reporter some time to
174
174
respond or self-close their issue if it's determined that the behavior is not a bug,
175
175
or the feature is out of scope. Sometimes reporters just go away though, and
176
176
we'll close the issue after the conversation has died.
177
+
If you think an issue should be closed but are not completely sure, please apply
178
+
the "closing candidate" label and wait for other maintainers to take a look.
177
179
178
180
.. _maintaining.reviewing:
179
181
@@ -252,14 +254,16 @@ Cleaning up old pull requests
252
254
Occasionally, contributors are unable to finish off a pull request.
253
255
If some time has passed (two weeks, say) since the last review requesting changes,
254
256
gently ask if they're still interested in working on this. If another two weeks or
255
-
so passes with no response, thank them for their work and close the pull request.
256
-
Comment on the original issue that "There's a stalled PR at #1234 that may be
257
-
helpful.", and perhaps label the issue as "Good first issue" if the PR was relatively
258
-
close to being accepted.
257
+
so passes with no response, thank them for their work and then either:
259
258
260
-
Additionally, core-team members can push to contributors branches. This can be
261
-
helpful for pushing an important PR across the line, or for fixing a small
262
-
merge conflict.
259
+
- close the pull request;
260
+
- push to the contributor's branch to push their work over the finish line (if
261
+
you're part of ``pandas-core``). This can be helpful for pushing an important PR
262
+
across the line, or for fixing a small merge conflict.
263
+
264
+
If closing the pull request, then please comment on the original issue that
265
+
"There's a stalled PR at #1234 that may be helpful.", and perhaps label the issue
266
+
as "Good first issue" if the PR was relatively close to being accepted.
263
267
264
268
Becoming a pandas maintainer
265
269
----------------------------
@@ -276,12 +280,13 @@ The required steps for adding a maintainer are:
276
280
* ``pandas-core`` is for core team members
277
281
* ``pandas-triage`` is for pandas triage members
278
282
283
+
If adding to ``pandas-core``, there are two additional steps:
284
+
279
285
3. Add the contributor to the pandas Google group.
280
286
4. Create a pull request to add the contributor's GitHub handle to ``pandas-dev/pandas/web/pandas/config.yml``.
281
-
5. Create a pull request to add the contributor's name/GitHub handle to the `governance document <https://github.com/pandas-dev/pandas-governance/blob/master/people.md>`_.
.. _list of permissions: https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-roles-for-an-organization
Copy file name to clipboardExpand all lines: doc/source/getting_started/overview.rst
+2-2
Original file line number
Diff line number
Diff line change
@@ -154,15 +154,15 @@ project and makes it possible to `donate <https://pandas.pydata.org/donate.html>
154
154
Project governance
155
155
------------------
156
156
157
-
The governance process that pandas project has used informally since its inception in 2008 is formalized in `Project Governance documents <https://github.com/pandas-dev/pandas-governance>`__.
157
+
The governance process that pandas project has used informally since its inception in 2008 is formalized in `Project Governance documents <https://github.com/pandas-dev/pandas/blob/main/web/pandas/about/governance.md>`__.
158
158
The documents clarify how decisions are made and how the various elements of our community interact, including the relationship between open source collaborative development and work that may be funded by for-profit or non-profit entities.
159
159
160
160
Wes McKinney is the Benevolent Dictator for Life (BDFL).
161
161
162
162
Development team
163
163
-----------------
164
164
165
-
The list of the Core Team members and more detailed information can be found on the `people’s page<https://github.com/pandas-dev/pandas-governance/blob/master/people.md>`__ of the governance repo.
165
+
The list of the Core Team members and more detailed information can be found on the `pandas website<https://pandas.pydata.org/about/team.html>`__.
0 commit comments