Skip to content

Commit 5ea5570

Browse files
authored
WEB: remove links to pandas-governance + assorted cleanups (#52162)
* clean up maintainers guide, remove outdated links to pandas-governance * fix indent --------- Co-authored-by: MarcoGorelli <>
1 parent c61c7ba commit 5ea5570

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

doc/source/development/maintaining.rst

+15-10
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,8 @@ conversation is over. It's typically best to give the reporter some time to
174174
respond or self-close their issue if it's determined that the behavior is not a bug,
175175
or the feature is out of scope. Sometimes reporters just go away though, and
176176
we'll close the issue after the conversation has died.
177+
If you think an issue should be closed but are not completely sure, please apply
178+
the "closing candidate" label and wait for other maintainers to take a look.
177179

178180
.. _maintaining.reviewing:
179181

@@ -252,14 +254,16 @@ Cleaning up old pull requests
252254
Occasionally, contributors are unable to finish off a pull request.
253255
If some time has passed (two weeks, say) since the last review requesting changes,
254256
gently ask if they're still interested in working on this. If another two weeks or
255-
so passes with no response, thank them for their work and close the pull request.
256-
Comment on the original issue that "There's a stalled PR at #1234 that may be
257-
helpful.", and perhaps label the issue as "Good first issue" if the PR was relatively
258-
close to being accepted.
257+
so passes with no response, thank them for their work and then either:
259258

260-
Additionally, core-team members can push to contributors branches. This can be
261-
helpful for pushing an important PR across the line, or for fixing a small
262-
merge conflict.
259+
- close the pull request;
260+
- push to the contributor's branch to push their work over the finish line (if
261+
you're part of ``pandas-core``). This can be helpful for pushing an important PR
262+
across the line, or for fixing a small merge conflict.
263+
264+
If closing the pull request, then please comment on the original issue that
265+
"There's a stalled PR at #1234 that may be helpful.", and perhaps label the issue
266+
as "Good first issue" if the PR was relatively close to being accepted.
263267

264268
Becoming a pandas maintainer
265269
----------------------------
@@ -276,12 +280,13 @@ The required steps for adding a maintainer are:
276280
* ``pandas-core`` is for core team members
277281
* ``pandas-triage`` is for pandas triage members
278282

283+
If adding to ``pandas-core``, there are two additional steps:
284+
279285
3. Add the contributor to the pandas Google group.
280286
4. Create a pull request to add the contributor's GitHub handle to ``pandas-dev/pandas/web/pandas/config.yml``.
281-
5. Create a pull request to add the contributor's name/GitHub handle to the `governance document <https://github.com/pandas-dev/pandas-governance/blob/master/people.md>`_.
282287

283288
The current list of core-team members is at
284-
https://github.com/pandas-dev/pandas-governance/blob/master/people.md
289+
https://github.com/pandas-dev/pandas/blob/main/web/pandas/config.yml
285290

286291

287292
.. _maintaining.merging:
@@ -496,5 +501,5 @@ Post-Release
496501
- Twitter, Mastodon and Telegram
497502

498503

499-
.. _governance documents: https://github.com/pandas-dev/pandas-governance
504+
.. _governance documents: https://github.com/pandas-dev/pandas/blob/main/web/pandas/about/governance.md
500505
.. _list of permissions: https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-roles-for-an-organization

doc/source/getting_started/overview.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -154,15 +154,15 @@ project and makes it possible to `donate <https://pandas.pydata.org/donate.html>
154154
Project governance
155155
------------------
156156

157-
The governance process that pandas project has used informally since its inception in 2008 is formalized in `Project Governance documents <https://github.com/pandas-dev/pandas-governance>`__.
157+
The governance process that pandas project has used informally since its inception in 2008 is formalized in `Project Governance documents <https://github.com/pandas-dev/pandas/blob/main/web/pandas/about/governance.md>`__.
158158
The documents clarify how decisions are made and how the various elements of our community interact, including the relationship between open source collaborative development and work that may be funded by for-profit or non-profit entities.
159159

160160
Wes McKinney is the Benevolent Dictator for Life (BDFL).
161161

162162
Development team
163163
-----------------
164164

165-
The list of the Core Team members and more detailed information can be found on the `people’s page <https://github.com/pandas-dev/pandas-governance/blob/master/people.md>`__ of the governance repo.
165+
The list of the Core Team members and more detailed information can be found on the `pandas website <https://pandas.pydata.org/about/team.html>`__.
166166

167167

168168
Institutional partners

0 commit comments

Comments
 (0)