Skip to content

Commit 5cf0e3e

Browse files
author
Vraj Mohan
committed
Use pytest.parameterize to test all the cases
1 parent 7a66f3d commit 5cf0e3e

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

pandas/tests/io/test_sql.py

+8-6
Original file line numberDiff line numberDiff line change
@@ -823,18 +823,20 @@ def test_get_schema_keys(self):
823823
constraint_sentence = 'CONSTRAINT test_pk PRIMARY KEY ("A", "B")'
824824
assert constraint_sentence in create_sql
825825

826-
def test_get_schema_with_index(self):
826+
@pytest.mark.parametrize("index_arg, expected", [
827+
({}, False),
828+
({"index": False}, False),
829+
({"index": True}, True),
830+
])
831+
def test_get_schema_with_index(self, index_arg, expected):
827832
frame = DataFrame({
828833
'one': pd.Series([1, 2, 3], index=['a', 'b', 'c']),
829834
'two': pd.Series([1, 2, 3], index=['a', 'b', 'c'])
830835
})
831836
frame.index.name = 'alphabet'
832837

833-
create_sql = sql.get_schema(frame, 'test', con=self.conn)
834-
assert 'alphabet' not in create_sql
835-
836-
create_sql = sql.get_schema(frame, 'test', con=self.conn, index=True)
837-
assert 'alphabet' in create_sql
838+
create_sql = sql.get_schema(frame, 'test', con=self.conn, **index_arg)
839+
assert ('alphabet' in create_sql) == expected
838840

839841
def test_chunksize_read(self):
840842
df = DataFrame(np.random.randn(22, 5), columns=list('abcde'))

0 commit comments

Comments
 (0)