Skip to content

Commit 5c9aae2

Browse files
committed
TST/BUG: make sure read_html tests work on python 2.6
1 parent 6d9fa7f commit 5c9aae2

File tree

3 files changed

+22
-19
lines changed

3 files changed

+22
-19
lines changed

doc/source/release.rst

+1
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ pandas 0.13
6161
(:issue:`4353`)
6262
- Fixed an issue where ``DataFrame.sum`` was slower than ``DataFrame.mean``
6363
for integer valued frames (:issue:`4365`)
64+
- ``read_html`` tests now work with Python 2.6 (:issue:`4351`)
6465

6566
pandas 0.12
6667
===========

doc/source/v0.13.0.txt

+2
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ Bug Fixes
4141
- Fixed an issue where ``DataFrame.sum`` was slower than ``DataFrame.mean``
4242
for integer valued frames (:issue:`4365`)
4343

44+
- ``read_html`` tests now work with Python 2.6 (:issue:`4351`)
45+
4446
See the :ref:`full release notes
4547
<release>` or issue tracker
4648
on GitHub for a complete list.

pandas/io/tests/test_html.py

+19-19
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
from pandas.util.testing import (assert_frame_equal, network,
2626
get_data_path)
2727

28-
from pandas.util.testing import makeCustomDataframe as mkdf, rands
28+
from pandas.util.testing import makeCustomDataframe as mkdf
2929

3030

3131
def _have_module(module_name):
@@ -157,12 +157,12 @@ def test_spam(self):
157157
def test_spam_no_match(self):
158158
dfs = self.run_read_html(self.spam_data)
159159
for df in dfs:
160-
self.assertIsInstance(df, DataFrame)
160+
self.assert_(isinstance(df, DataFrame))
161161

162162
def test_banklist_no_match(self):
163163
dfs = self.run_read_html(self.banklist_data, attrs={'id': 'table'})
164164
for df in dfs:
165-
self.assertIsInstance(df, DataFrame)
165+
self.assert_(isinstance(df, DataFrame))
166166

167167
def test_spam_header(self):
168168
df = self.run_read_html(self.spam_data, '.*Water.*', header=0)
@@ -301,9 +301,9 @@ def test_file_url(self):
301301
url = self.banklist_data
302302
dfs = self.run_read_html('file://' + url, 'First',
303303
attrs={'id': 'table'})
304-
self.assertIsInstance(dfs, list)
304+
self.assert_(isinstance(dfs, list))
305305
for df in dfs:
306-
self.assertIsInstance(df, DataFrame)
306+
self.assert_(isinstance(df, DataFrame))
307307

308308
@slow
309309
def test_invalid_table_attrs(self):
@@ -319,38 +319,38 @@ def _bank_data(self, *args, **kwargs):
319319
@slow
320320
def test_multiindex_header(self):
321321
df = self._bank_data(header=[0, 1])[0]
322-
self.assertIsInstance(df.columns, MultiIndex)
322+
self.assert_(isinstance(df.columns, MultiIndex))
323323

324324
@slow
325325
def test_multiindex_index(self):
326326
df = self._bank_data(index_col=[0, 1])[0]
327-
self.assertIsInstance(df.index, MultiIndex)
327+
self.assert_(isinstance(df.index, MultiIndex))
328328

329329
@slow
330330
def test_multiindex_header_index(self):
331331
df = self._bank_data(header=[0, 1], index_col=[0, 1])[0]
332-
self.assertIsInstance(df.columns, MultiIndex)
333-
self.assertIsInstance(df.index, MultiIndex)
332+
self.assert_(isinstance(df.columns, MultiIndex))
333+
self.assert_(isinstance(df.index, MultiIndex))
334334

335335
@slow
336336
def test_multiindex_header_skiprows(self):
337337
df = self._bank_data(header=[0, 1], skiprows=1)[0]
338-
self.assertIsInstance(df.columns, MultiIndex)
338+
self.assert_(isinstance(df.columns, MultiIndex))
339339

340340
@slow
341341
def test_multiindex_header_index_skiprows(self):
342342
df = self._bank_data(header=[0, 1], index_col=[0, 1], skiprows=1)[0]
343-
self.assertIsInstance(df.index, MultiIndex)
343+
self.assert_(isinstance(df.index, MultiIndex))
344344

345345
@slow
346346
def test_regex_idempotency(self):
347347
url = self.banklist_data
348348
dfs = self.run_read_html('file://' + url,
349349
match=re.compile(re.compile('Florida')),
350350
attrs={'id': 'table'})
351-
self.assertIsInstance(dfs, list)
351+
self.assert_(isinstance(dfs, list))
352352
for df in dfs:
353-
self.assertIsInstance(df, DataFrame)
353+
self.assert_(isinstance(df, DataFrame))
354354

355355
def test_negative_skiprows_spam(self):
356356
url = self.spam_data
@@ -367,15 +367,15 @@ def test_multiple_matches(self):
367367
url = 'http://code.google.com/p/pythonxy/wiki/StandardPlugins'
368368
dfs = self.run_read_html(url, match='Python',
369369
attrs={'class': 'wikitable'})
370-
self.assertGreater(len(dfs), 1)
370+
self.assert_(len(dfs) > 1)
371371

372372
@network
373373
def test_pythonxy_plugins_table(self):
374374
url = 'http://code.google.com/p/pythonxy/wiki/StandardPlugins'
375375
dfs = self.run_read_html(url, match='Python',
376376
attrs={'class': 'wikitable'})
377377
zz = [df.iloc[0, 0] for df in dfs]
378-
self.assertListEqual(sorted(zz), sorted(['Python', 'SciTE']))
378+
self.assertEqual(sorted(zz), sorted(['Python', 'SciTE']))
379379

380380
@slow
381381
def test_banklist_header(self):
@@ -391,7 +391,7 @@ def try_remove_ws(x):
391391
ground_truth = read_csv(os.path.join(DATA_PATH, 'banklist.csv'),
392392
converters={'Updated Date': Timestamp,
393393
'Closing Date': Timestamp})
394-
self.assertTupleEqual(df.shape, ground_truth.shape)
394+
self.assertEqual(df.shape, ground_truth.shape)
395395
old = ['First Vietnamese American BankIn Vietnamese',
396396
'Westernbank Puerto RicoEn Espanol',
397397
'R-G Premier Bank of Puerto RicoEn Espanol',
@@ -422,7 +422,7 @@ def test_gold_canyon(self):
422422
self.assert_(gc in raw_text)
423423
df = self.run_read_html(self.banklist_data, 'Gold Canyon',
424424
attrs={'id': 'table'}, infer_types=False)[0]
425-
self.assertIn(gc, df.to_string())
425+
self.assert_(gc in df.to_string())
426426

427427

428428
class TestReadHtmlLxml(TestCase):
@@ -449,8 +449,8 @@ def test_banklist_data_fail(self):
449449
def test_works_on_valid_markup(self):
450450
filename = os.path.join(DATA_PATH, 'valid_markup.html')
451451
dfs = self.run_read_html(filename, index_col=0, flavor=['lxml'])
452-
self.assertIsInstance(dfs, list)
453-
self.assertIsInstance(dfs[0], DataFrame)
452+
self.assert_(isinstance(dfs, list))
453+
self.assert_(isinstance(dfs[0], DataFrame))
454454

455455
def setUp(self):
456456
self.try_skip()

0 commit comments

Comments
 (0)