TST: stricten xfails (#38927)

Author: jbrockmendel

pandas/tests/frame/test_arithmetic.py

@@ -821,7 +821,6 @@ def test_frame_with_frame_reindex(self):
             (np.datetime64(20, "ns"), "<M8[ns]"),
         ],
     )
-    @pytest.mark.xfail(reason="GH38630", strict=False)
     @pytest.mark.parametrize(
         "op",
         [
@@ -835,9 +834,12 @@ def test_frame_with_frame_reindex(self):
         ids=lambda x: x.__name__,
     )
     def test_binop_other(self, op, value, dtype):
+
         skip = {
             (operator.truediv, "bool"),
             (operator.pow, "bool"),
+            (operator.add, "bool"),
+            (operator.mul, "bool"),
         }
 
         e = DummyElement(value, dtype)
@@ -879,12 +881,18 @@ def test_binop_other(self, op, value, dtype):
 
         elif (op, dtype) in skip:
 
-            msg = "operator '.*' not implemented for .* dtypes"
-            with pytest.raises(NotImplementedError, match=msg):
+            if op in [operator.add, operator.mul]:
                 with tm.assert_produces_warning(UserWarning):
                     # "evaluating in Python space because ..."
                     op(s, e.value)
 
+            else:
+                msg = "operator '.*' not implemented for .* dtypes"
+                with pytest.raises(NotImplementedError, match=msg):
+                    with tm.assert_produces_warning(UserWarning):
+                        # "evaluating in Python space because ..."
+                        op(s, e.value)
+
         else:
             # FIXME: Since dispatching to Series, this test no longer
             # asserts anything meaningful

pandas/tests/indexes/test_common.py

@@ -16,12 +16,10 @@
 from pandas import (
     CategoricalIndex,
     DatetimeIndex,
-    Int64Index,
     MultiIndex,
     PeriodIndex,
     RangeIndex,
     TimedeltaIndex,
-    UInt64Index,
 )
 import pandas._testing as tm
 
@@ -371,12 +369,9 @@ def test_ravel_deprecation(self, index):
         with tm.assert_produces_warning(FutureWarning):
             index.ravel()
 
-    @pytest.mark.xfail(reason="GH38630", strict=False)
     def test_asi8_deprecation(self, index):
         # GH#37877
-        if isinstance(
-            index, (Int64Index, UInt64Index, DatetimeIndex, TimedeltaIndex, PeriodIndex)
-        ):
+        if isinstance(index, (DatetimeIndex, TimedeltaIndex, PeriodIndex)):
             warn = None
         else:
             warn = FutureWarning