Skip to content

Commit 56094aa

Browse files
author
Thomas Grainger
committed
remember to close the result set
1 parent 5c5c9bd commit 56094aa

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

pandas/io/tests/test_sql.py

+5-10
Original file line numberDiff line numberDiff line change
@@ -1489,20 +1489,15 @@ def test_read_procedure(self):
14891489
SELECT * FROM test_procedure;
14901490
END"""
14911491

1492-
connection = self.conn.connect()
1493-
trans = connection.begin()
1494-
try:
1495-
r1 = connection.execute(proc)
1496-
trans.commit()
1497-
except:
1498-
trans.rollback()
1499-
raise
1492+
with self.conn.connect() as connection:
1493+
with connection.begin():
1494+
connection.execute(proc).close()
15001495

1501-
res1 = sql.read_sql_query("CALL get_testdb();", self.conn)
1496+
res1 = sql.read_sql_query("CALL get_testdb()", self.conn)
15021497
tm.assert_frame_equal(df, res1)
15031498

15041499
# test delegation to read_sql_query
1505-
res2 = sql.read_sql("CALL get_testdb();", self.conn)
1500+
res2 = sql.read_sql("CALL get_testdb()", self.conn)
15061501
tm.assert_frame_equal(df, res2)
15071502

15081503

0 commit comments

Comments
 (0)