Clean up

Author: MarcoGorelli

pandas/core/arrays/categorical.py

@@ -1824,6 +1824,7 @@ def fillna(self, value=None, method=None, limit=None):
 
         # pad / bfill
         if method is not None:
+
             values = self.to_dense().reshape(-1, len(self))
             values = interpolate_2d(values, method, 0, None, value).astype(
                 self.categories.dtype
@@ -1837,9 +1838,10 @@ def fillna(self, value=None, method=None, limit=None):
             if isinstance(value, ABCSeries):
                 if not value[~value.isin(self.categories)].isna().all():
                     raise ValueError("fill value must be in categories")
+
                 values_codes = _get_codes_for_values(value, self.categories)
                 indexer = np.where(codes == -1)
-                codes[indexer] = values_codes[codes == -1]
+                codes[indexer] = values_codes[indexer]
 
             # If value is not a dict or Series it should be a scalar
             elif is_hashable(value):