Skip to content

Commit 54da197

Browse files
committed
Revert "iloc and loc return new object when slice is a tuple"
This reverts commit 5daffa8.
1 parent 5daffa8 commit 54da197

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

pandas/core/indexing.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -845,7 +845,7 @@ def _getitem_tuple(self, tup):
845845
return self._multi_take(tup)
846846

847847
# no shortcut needed
848-
retval = self.obj.copy()
848+
retval = self.obj
849849
for i, key in enumerate(tup):
850850
if i >= self.obj.ndim:
851851
raise IndexingError('Too many indexers')
@@ -854,6 +854,7 @@ def _getitem_tuple(self, tup):
854854
continue
855855

856856
retval = getattr(retval, self.name)._getitem_axis(key, axis=i)
857+
857858
return retval
858859

859860
def _multi_take_opportunity(self, tup):
@@ -1664,7 +1665,7 @@ def _getitem_tuple(self, tup):
16641665
except:
16651666
pass
16661667

1667-
retval = self.obj.copy()
1668+
retval = self.obj
16681669
axis = 0
16691670
for i, key in enumerate(tup):
16701671
if i >= self.obj.ndim:

pandas/tests/indexing/test_iloc.py

-2
Original file line numberDiff line numberDiff line change
@@ -596,5 +596,3 @@ def test_loc_identity_slice_returns_new_object(self):
596596
# GH13873
597597
df = DataFrame({'a': [1, 3, 5], 'b': [2, 4, 6]})
598598
assert not df.iloc[:] is df
599-
assert not df.iloc[:,:] is df
600-
assert not df.iloc[pd.IndexSlice[:, :]] is df

pandas/tests/indexing/test_loc.py

-2
Original file line numberDiff line numberDiff line change
@@ -635,5 +635,3 @@ def test_loc_identity_slice_returns_new_object(self):
635635
# GH13873
636636
df = DataFrame({'a': [1, 3, 5], 'b': [2, 4, 6]})
637637
assert not df.loc[:] is df
638-
assert not df.loc[:,:] is df
639-
assert not df.loc[pd.IndexSlice[:, :]] is df

0 commit comments

Comments
 (0)