Merge pull request #5132 from jtratner/fix-set-names-error

BUG: set_names should not change is_ relationship

Author: jtratner

pandas/core/index.py

@@ -335,7 +335,6 @@ def set_names(self, names, inplace=False):
             raise TypeError("Must pass list-like as `names`.")
         if inplace:
             idx = self
-            idx._reset_identity()
         else:
             idx = self._shallow_copy()
         idx._set_names(names)

pandas/tests/test_index.py

@@ -1887,6 +1887,9 @@ def test_is_(self):
         self.assertTrue(mi2.is_(mi))
         self.assertTrue(mi.is_(mi2))
         self.assertTrue(mi.is_(mi.set_names(["C", "D"])))
+        mi2 = mi.view()
+        mi2.set_names(["E", "F"], inplace=True)
+        self.assertTrue(mi.is_(mi2))
         # levels are inherent properties, they change identity
         mi3 = mi2.set_levels([lrange(10), lrange(10)])
         self.assertFalse(mi3.is_(mi2))