CLN/TST: fail with a NotImplementedError on and or not

Author: cpcloud

pandas/computation/expr.py

@@ -77,6 +77,8 @@ def visit_BinOp(self, node):
         return op(left, right)
 
     def visit_UnaryOp(self, node):
+        if isinstance(node.op, ast.Not):
+            raise NotImplementedError("not operator not yet supported")
         op = self.visit(node.op)
         return op(self.visit(node.operand))
 
@@ -107,6 +109,8 @@ def visit_Call(self, node):
     def visit_Attribute(self, node):
         raise NotImplementedError("attribute access is not yet supported")
 
+    def visit_BoolOp(self, node):
+        raise NotImplementedError("boolean operators are not yet supported")
 
 class Expr(StringMixin):
     """Expr object"""

pandas/computation/tests/test_eval.py

@@ -610,6 +610,39 @@ def test_is_expr():
         check_is_expr(engine)
 
 
+def check_not_fails(engine):
+    x = True
+    assert_raises(NotImplementedError, pd.eval, 'not x', engine=engine,
+                  local_dict={'x': x})
+
+
+def test_not_fails():
+    for engine in _engines:
+        check_not_fails(engine)
+
+
+def check_and_fails(engine):
+    x, y = False, True
+    assert_raises(NotImplementedError, pd.eval, 'x and y', engine=engine,
+                  local_dict={'x': x, 'y': y})
+
+
+def test_and_fails():
+    for engine in _engines:
+        check_and_fails(engine)
+
+
+def check_or_fails(engine):
+    x, y = True, False
+    assert_raises(NotImplementedError, pd.eval, 'x or y', engine=engine,
+                  local_dict={'x': x, 'y': y})
+
+
+def test_or_fails():
+    for engine in _engines:
+        check_or_fails(engine)
+
+
 if __name__ == '__main__':
     nose.runmodule(argv=[__file__, '-vvs', '-x', '--pdb', '--pdb-failure'],
                    exit=False)