Merge pull request #5434 from jreback/test_fix

BUG/TST: bug in the test apparatus when dtypes are equal in a Series but the values are not equal

Author: jreback

pandas/src/testing.pyx

@@ -88,9 +88,10 @@ cpdef assert_almost_equal(a, b, bint check_less_precise=False):
                     return True
             except:
                 pass
-        else:
-            for i in xrange(na):
-                assert_almost_equal(a[i], b[i], check_less_precise)
+
+        for i in xrange(na):
+            assert_almost_equal(a[i], b[i], check_less_precise)
+
         return True
     elif isiterable(b):
         assert False, (

pandas/tests/test_testing.py

@@ -6,9 +6,9 @@
 import nose
 import numpy as np
 import sys
-
+from pandas import Series
 from pandas.util.testing import (
-    assert_almost_equal, assertRaisesRegexp, raise_with_traceback
+    assert_almost_equal, assertRaisesRegexp, raise_with_traceback, assert_series_equal
 )
 
 # let's get meta.
@@ -127,3 +127,29 @@ def test_raise_with_traceback(self):
                 e = LookupError("error_text")
                 _, _, traceback = sys.exc_info()
                 raise_with_traceback(e, traceback)
+
+class TestAssertSeriesEqual(unittest.TestCase):
+    _multiprocess_can_split_ = True
+
+    def _assert_equal(self, x, y, **kwargs):
+        assert_series_equal(x,y,**kwargs)
+        assert_series_equal(y,x,**kwargs)
+
+    def _assert_not_equal(self, a, b, **kwargs):
+        self.assertRaises(AssertionError, assert_series_equal, a, b, **kwargs)
+        self.assertRaises(AssertionError, assert_series_equal, b, a, **kwargs)
+
+    def test_equal(self):
+        self._assert_equal(Series(range(3)),Series(range(3)))
+        self._assert_equal(Series(list('abc')),Series(list('abc')))
+
+    def test_not_equal(self):
+        self._assert_not_equal(Series(range(3)),Series(range(3))+1)
+        self._assert_not_equal(Series(list('abc')),Series(list('xyz')))
+        self._assert_not_equal(Series(range(3)),Series(range(4)))
+        self._assert_not_equal(Series(range(3)),Series(range(3),dtype='float64'))
+        self._assert_not_equal(Series(range(3)),Series(range(3),index=[1,2,4]))
+
+        # ATM meta data is not checked in assert_series_equal
+        # self._assert_not_equal(Series(range(3)),Series(range(3),name='foo'),check_names=True)
+