Skip to content

Commit 4c6770d

Browse files
committed
CLN: Work on converting assert_'s to specialized forms, in pandas/tests
Work on #6175, in pandas/tests. Tests still pass locally. A work-in-progress, but--with #6261--removes many/most cases of assert_(x == y) in this directory
1 parent 9910dde commit 4c6770d

9 files changed

+297
-297
lines changed

pandas/tests/test_index.py

+38-38
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def test_hash_error(self):
9292

9393
def test_new_axis(self):
9494
new_index = self.dateIndex[None, :]
95-
self.assert_(new_index.ndim == 2)
95+
self.assertEqual(new_index.ndim, 2)
9696
tm.assert_isinstance(new_index, np.ndarray)
9797

9898
def test_copy_and_deepcopy(self):
@@ -133,7 +133,7 @@ def test_constructor(self):
133133
arr = np.array(self.strIndex)
134134
index = Index(arr, copy=True, name='name')
135135
tm.assert_isinstance(index, Index)
136-
self.assert_(index.name == 'name')
136+
self.assertEqual(index.name, 'name')
137137
assert_array_equal(arr, index)
138138
arr[0] = "SOMEBIGLONGSTRING"
139139
self.assertNotEqual(index[0], "SOMEBIGLONGSTRING")
@@ -156,12 +156,12 @@ def test_index_ctor_infer_periodindex(self):
156156
def test_copy(self):
157157
i = Index([], name='Foo')
158158
i_copy = i.copy()
159-
self.assert_(i_copy.name == 'Foo')
159+
self.assertEqual(i_copy.name, 'Foo')
160160

161161
def test_view(self):
162162
i = Index([], name='Foo')
163163
i_view = i.view()
164-
self.assert_(i_view.name == 'Foo')
164+
self.assertEqual(i_view.name, 'Foo')
165165

166166
def test_astype(self):
167167
casted = self.intIndex.astype('i8')
@@ -234,7 +234,7 @@ def test_asof(self):
234234
self.assert_(np.isnan(self.dateIndex.asof(d - timedelta(1))))
235235

236236
d = self.dateIndex[-1]
237-
self.assert_(self.dateIndex.asof(d + timedelta(1)) == d)
237+
self.assertEqual(self.dateIndex.asof(d + timedelta(1)), d)
238238

239239
d = self.dateIndex[0].to_datetime()
240240
tm.assert_isinstance(self.dateIndex.asof(d), Timestamp)
@@ -356,7 +356,7 @@ def test_union(self):
356356
first.name = 'A'
357357
second.name = 'A'
358358
union = first.union(second)
359-
self.assert_(union.name == 'A')
359+
self.assertEqual(union.name, 'A')
360360

361361
second.name = 'B'
362362
union = first.union(second)
@@ -393,7 +393,7 @@ def test_append_empty_preserve_name(self):
393393
right = Index([1, 2, 3], name='foo')
394394

395395
result = left.append(right)
396-
self.assert_(result.name == 'foo')
396+
self.assertEqual(result.name, 'foo')
397397

398398
left = Index([], name='foo')
399399
right = Index([1, 2, 3], name='bar')
@@ -440,7 +440,7 @@ def test_diff(self):
440440

441441
# with everythin
442442
result = first.diff(first)
443-
self.assert_(len(result) == 0)
443+
self.assertEqual(len(result), 0)
444444
self.assertEqual(result.name, first.name)
445445

446446
# non-iterable input
@@ -511,14 +511,14 @@ def test_format_with_name_time_info(self):
511511
dates = Index([dt + inc for dt in self.dateIndex], name='something')
512512

513513
formatted = dates.format(name=True)
514-
self.assert_(formatted[0] == 'something')
514+
self.assertEqual(formatted[0], 'something')
515515

516516
def test_format_datetime_with_time(self):
517517
t = Index([datetime(2012, 2, 7), datetime(2012, 2, 7, 23)])
518518

519519
result = t.format()
520520
expected = ['2012-02-07 00:00:00', '2012-02-07 23:00:00']
521-
self.assert_(len(result) == 2)
521+
self.assertEqual(len(result), 2)
522522
self.assertEquals(result, expected)
523523

524524
def test_format_none(self):
@@ -579,16 +579,16 @@ def test_slice_locs(self):
579579
def test_slice_locs_dup(self):
580580
idx = Index(['a', 'a', 'b', 'c', 'd', 'd'])
581581
rs = idx.slice_locs('a', 'd')
582-
self.assert_(rs == (0, 6))
582+
self.assertEqual(rs, (0, 6))
583583

584584
rs = idx.slice_locs(end='d')
585-
self.assert_(rs == (0, 6))
585+
self.assertEqual(rs, (0, 6))
586586

587587
rs = idx.slice_locs('a', 'c')
588-
self.assert_(rs == (0, 4))
588+
self.assertEqual(rs, (0, 4))
589589

590590
rs = idx.slice_locs('b', 'd')
591-
self.assert_(rs == (2, 6))
591+
self.assertEqual(rs, (2, 6))
592592

593593
def test_drop(self):
594594
n = len(self.strIndex)
@@ -624,13 +624,13 @@ def test_tuple_union_bug(self):
624624
int_idx = idx1.intersection(idx2)
625625
# needs to be 1d like idx1 and idx2
626626
expected = idx1[:4] # pandas.Index(sorted(set(idx1) & set(idx2)))
627-
self.assert_(int_idx.ndim == 1)
627+
self.assertEqual(int_idx.ndim, 1)
628628
self.assert_(int_idx.equals(expected))
629629

630630
# union broken
631631
union_idx = idx1.union(idx2)
632632
expected = pandas.Index(sorted(set(idx1) | set(idx2)))
633-
self.assert_(union_idx.ndim == 1)
633+
self.assertEqual(union_idx.ndim, 1)
634634
self.assert_(union_idx.equals(expected))
635635

636636
def test_is_monotonic_incomparable(self):
@@ -658,8 +658,8 @@ def test_isin(self):
658658
# empty, return dtype bool
659659
idx = Index([])
660660
result = idx.isin(values)
661-
self.assert_(len(result) == 0)
662-
self.assert_(result.dtype == np.bool_)
661+
self.assertEqual(len(result), 0)
662+
self.assertEqual(result.dtype, np.bool_)
663663

664664
def test_boolean_cmp(self):
665665
values = [1, 2, 3, 4]
@@ -668,7 +668,7 @@ def test_boolean_cmp(self):
668668
res = (idx == values)
669669

670670
self.assert_(res.all())
671-
self.assert_(res.dtype == 'bool')
671+
self.assertEqual(res.dtype, 'bool')
672672
self.assert_(not isinstance(res, Index))
673673

674674
def test_get_level_values(self):
@@ -728,15 +728,15 @@ def test_constructor(self):
728728
self.assert_(isinstance(index, Float64Index))
729729
index = Float64Index(np.array([1.,2,3,4,5]))
730730
self.assert_(isinstance(index, Float64Index))
731-
self.assert_(index.dtype == object)
731+
self.assertEqual(index.dtype, object)
732732

733733
index = Float64Index(np.array([1.,2,3,4,5]),dtype=np.float32)
734734
self.assert_(isinstance(index, Float64Index))
735-
self.assert_(index.dtype == object)
735+
self.assertEqual(index.dtype, object)
736736

737737
index = Float64Index(np.array([1,2,3,4,5]),dtype=np.float32)
738738
self.assert_(isinstance(index, Float64Index))
739-
self.assert_(index.dtype == object)
739+
self.assertEqual(index.dtype, object)
740740

741741
# nan handling
742742
result = Float64Index([np.nan, np.nan])
@@ -818,7 +818,7 @@ def test_constructor(self):
818818
def test_constructor_corner(self):
819819
arr = np.array([1, 2, 3, 4], dtype=object)
820820
index = Int64Index(arr)
821-
self.assert_(index.values.dtype == np.int64)
821+
self.assertEqual(index.values.dtype, np.int64)
822822
self.assert_(index.equals(arr))
823823

824824
# preventing casting
@@ -839,12 +839,12 @@ def test_hash_error(self):
839839
def test_copy(self):
840840
i = Int64Index([], name='Foo')
841841
i_copy = i.copy()
842-
self.assert_(i_copy.name == 'Foo')
842+
self.assertEqual(i_copy.name, 'Foo')
843843

844844
def test_view(self):
845845
i = Int64Index([], name='Foo')
846846
i_view = i.view()
847-
self.assert_(i_view.name == 'Foo')
847+
self.assertEqual(i_view.name, 'Foo')
848848

849849
def test_coerce_list(self):
850850
# coerce things
@@ -856,7 +856,7 @@ def test_coerce_list(self):
856856
tm.assert_isinstance(arr, Index)
857857

858858
def test_dtype(self):
859-
self.assert_(self.index.dtype == np.int64)
859+
self.assertEqual(self.index.dtype, np.int64)
860860

861861
def test_is_monotonic(self):
862862
self.assert_(self.index.is_monotonic)
@@ -1123,7 +1123,7 @@ def test_intersect_str_dates(self):
11231123
i2 = Index(['aa'], dtype=object)
11241124
res = i2.intersection(i1)
11251125

1126-
self.assert_(len(res) == 0)
1126+
self.assertEqual(len(res), 0)
11271127

11281128
def test_union_noncomparable(self):
11291129
from datetime import datetime, timedelta
@@ -1152,7 +1152,7 @@ def test_view_Index(self):
11521152

11531153
def test_prevent_casting(self):
11541154
result = self.index.astype('O')
1155-
self.assert_(result.dtype == np.object_)
1155+
self.assertEqual(result.dtype, np.object_)
11561156

11571157
def test_take_preserve_name(self):
11581158
index = Int64Index([1, 2, 3, 4], name='foo')
@@ -1223,7 +1223,7 @@ def test_hash_error(self):
12231223

12241224
def test_set_names_and_rename(self):
12251225
# so long as these are synonyms, we don't need to test set_names
1226-
self.assert_(self.index.rename == self.index.set_names)
1226+
self.assertEqual(self.index.rename, self.index.set_names)
12271227
new_names = [name + "SUFFIX" for name in self.index_names]
12281228
ind = self.index.set_names(new_names)
12291229
self.assertEqual(self.index.names, self.index_names)
@@ -1433,7 +1433,7 @@ def test_constructor_single_level(self):
14331433
names=['first'])
14341434
tm.assert_isinstance(single_level, Index)
14351435
self.assert_(not isinstance(single_level, MultiIndex))
1436-
self.assert_(single_level.name == 'first')
1436+
self.assertEqual(single_level.name, 'first')
14371437

14381438
single_level = MultiIndex(levels=[['foo', 'bar', 'baz', 'qux']],
14391439
labels=[[0, 1, 2, 3]])
@@ -1644,7 +1644,7 @@ def test_iter(self):
16441644
result = list(self.index)
16451645
expected = [('foo', 'one'), ('foo', 'two'), ('bar', 'one'),
16461646
('baz', 'two'), ('qux', 'one'), ('qux', 'two')]
1647-
self.assert_(result == expected)
1647+
self.assertEqual(result, expected)
16481648

16491649
def test_pickle(self):
16501650
pickled = pickle.dumps(self.index)
@@ -1735,8 +1735,8 @@ def test_getitem_group_select(self):
17351735
self.assertEquals(sorted_idx.get_loc('foo'), slice(0, 2))
17361736

17371737
def test_get_loc(self):
1738-
self.assert_(self.index.get_loc(('foo', 'two')) == 1)
1739-
self.assert_(self.index.get_loc(('baz', 'two')) == 3)
1738+
self.assertEqual(self.index.get_loc(('foo', 'two')), 1)
1739+
self.assertEqual(self.index.get_loc(('baz', 'two')), 3)
17401740
self.assertRaises(KeyError, self.index.get_loc, ('bar', 'two'))
17411741
self.assertRaises(KeyError, self.index.get_loc, 'quux')
17421742

@@ -1748,13 +1748,13 @@ def test_get_loc(self):
17481748
np.array([0, 1, 0, 0, 0, 1, 0, 1]),
17491749
np.array([1, 0, 1, 1, 0, 0, 1, 0])])
17501750
self.assertRaises(KeyError, index.get_loc, (1, 1))
1751-
self.assert_(index.get_loc((2, 0)) == slice(3, 5))
1751+
self.assertEqual(index.get_loc((2, 0)), slice(3, 5))
17521752

17531753
def test_get_loc_duplicates(self):
17541754
index = Index([2, 2, 2, 2])
17551755
result = index.get_loc(2)
17561756
expected = slice(0, 4)
1757-
assert(result == expected)
1757+
self.assertEqual(result, expected)
17581758
# self.assertRaises(Exception, index.get_loc, 2)
17591759

17601760
index = Index(['c', 'a', 'a', 'b', 'b'])
@@ -2213,7 +2213,7 @@ def test_diff(self):
22132213

22142214
# empty, but non-equal
22152215
result = self.index - self.index.sortlevel(1)[0]
2216-
self.assert_(len(result) == 0)
2216+
self.assertEqual(len(result), 0)
22172217

22182218
# raise Exception called with non-MultiIndex
22192219
result = first.diff(first._tuple_index)
@@ -2352,15 +2352,15 @@ def test_insert(self):
23522352
# key contained in all levels
23532353
new_index = self.index.insert(0, ('bar', 'two'))
23542354
self.assert_(new_index.equal_levels(self.index))
2355-
self.assert_(new_index[0] == ('bar', 'two'))
2355+
self.assertEqual(new_index[0], ('bar', 'two'))
23562356

23572357
# key not contained in all levels
23582358
new_index = self.index.insert(0, ('abc', 'three'))
23592359
self.assert_(np.array_equal(new_index.levels[0],
23602360
list(self.index.levels[0]) + ['abc']))
23612361
self.assert_(np.array_equal(new_index.levels[1],
23622362
list(self.index.levels[1]) + ['three']))
2363-
self.assert_(new_index[0] == ('abc', 'three'))
2363+
self.assertEqual(new_index[0], ('abc', 'three'))
23642364

23652365
# key wrong length
23662366
assertRaisesRegexp(ValueError, "Item must have length equal to number"

0 commit comments

Comments
 (0)