Skip to content

Commit 45b838a

Browse files
Preserve name for DatetimeIndex field accessors
1 parent 76d1564 commit 45b838a

File tree

2 files changed

+13
-19
lines changed

2 files changed

+13
-19
lines changed

pandas/tests/indexes/datetimes/test_misc.py

+12-18
Original file line numberDiff line numberDiff line change
@@ -230,24 +230,18 @@ def test_datetimeindex_accessors(self):
230230
self.assertEqual(Timestamp('2016-04-09').weekday_name, u'Saturday')
231231
self.assertEqual(Timestamp('2016-04-10').weekday_name, u'Sunday')
232232

233-
self.assertEqual(len(dti.year), 365)
234-
self.assertEqual(len(dti.month), 365)
235-
self.assertEqual(len(dti.day), 365)
236-
self.assertEqual(len(dti.hour), 365)
237-
self.assertEqual(len(dti.minute), 365)
238-
self.assertEqual(len(dti.second), 365)
239-
self.assertEqual(len(dti.microsecond), 365)
240-
self.assertEqual(len(dti.dayofweek), 365)
241-
self.assertEqual(len(dti.dayofyear), 365)
242-
self.assertEqual(len(dti.weekofyear), 365)
243-
self.assertEqual(len(dti.quarter), 365)
244-
self.assertEqual(len(dti.is_month_start), 365)
245-
self.assertEqual(len(dti.is_month_end), 365)
246-
self.assertEqual(len(dti.is_quarter_start), 365)
247-
self.assertEqual(len(dti.is_quarter_end), 365)
248-
self.assertEqual(len(dti.is_year_start), 365)
249-
self.assertEqual(len(dti.is_year_end), 365)
250-
self.assertEqual(len(dti.weekday_name), 365)
233+
dti.name = 'name'
234+
235+
for accessor in ['year', 'month', 'day', 'hour', 'minute', 'second',
236+
'microsecond', 'nanosecond', 'dayofweek', 'dayofyear',
237+
'weekofyear', 'quarter',
238+
'is_month_start', 'is_month_end',
239+
'is_quarter_start', 'is_quarter_end',
240+
'is_year_start', 'is_year_end', 'weekday_name']:
241+
res = getattr(dti, accessor)
242+
self.assertEqual(len(res), 365)
243+
self.assertIsInstance(res, Index)
244+
self.assertEqual(res.name, 'name')
251245

252246
dti = DatetimeIndex(freq='BQ-FEB', start=datetime(1998, 1, 1),
253247
periods=4)

pandas/tseries/index.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def f(self):
8989
result = tslib.get_date_field(values, field)
9090
result = self._maybe_mask_results(result, convert='float64')
9191

92-
return Index(result)
92+
return Index(result, name=self.name)
9393

9494
f.__name__ = name
9595
f.__doc__ = docstring

0 commit comments

Comments
 (0)