Skip to content

Commit 44c9a14

Browse files
committed
Add test
1 parent f3045db commit 44c9a14

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

pandas/tests/frame/methods/test_combine_first.py

+11-1
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ def test_combine_first_with_asymmetric_other(self, val):
380380
df2 = DataFrame({"isBool": [True]})
381381

382382
res = df1.combine_first(df2)
383-
exp = DataFrame({"isBool": [True], "isNum": [val]})
383+
exp = DataFrame({"isNum": [val], "isBool": [True]})
384384

385385
tm.assert_frame_equal(res, exp)
386386

@@ -555,3 +555,13 @@ def test_combine_first_empty_columns():
555555
result = left.combine_first(right)
556556
expected = DataFrame(columns=["a", "b", "c"])
557557
tm.assert_frame_equal(result, expected)
558+
559+
560+
def test_combine_first_preserve_column_order():
561+
# GH#60427
562+
df1 = DataFrame({"B": [1, 2, 3], "A": [4, None, 6]})
563+
df2 = DataFrame({"A": [5]}, index=[1])
564+
565+
result = df1.combine_first(df2)
566+
expected = DataFrame({"B": [1, 2, 3], "A": [4.0, 5.0, 6.0]})
567+
tm.assert_frame_equal(result, expected)

0 commit comments

Comments
 (0)