restore/add comments re: floating point errors

arw2019 · arw2019 · commit 416035ba512c · 2020-09-18T17:59:59.000Z
diff --git a/pandas/tests/tools/test_to_datetime.py b/pandas/tests/tools/test_to_datetime.py
@@ -1217,6 +1217,8 @@ def test_unit_mixed(self, cache):
 
     @pytest.mark.parametrize("cache", [True, False])
     def test_unit_rounding(self, cache):
+        # GH 14156 & GH 20445: argument will incur floating point errors
+        # but no premature rounding
         result = pd.to_datetime(1434743731.8770001, unit="s", cache=cache)
         expected = pd.Timestamp("2015-06-19 19:55:31.877000192")
         assert result == expected
@@ -1452,6 +1454,7 @@ def test_to_datetime_unit(self):
             ]
             + [NaT]
         )
+        # GH20455 argument will incur floating point errors but no premature rounding
         result = result.round("ms")
         tm.assert_series_equal(result, expected)
 

Original file line number	Diff line number	Diff line change
`@@ -1217,6 +1217,8 @@ def test_unit_mixed(self, cache):`
`1217`	`1217`
`1218`	`1218`	`@pytest.mark.parametrize("cache", [True, False])`
`1219`	`1219`	`def test_unit_rounding(self, cache):`
	`1220`	`+ # GH 14156 & GH 20445: argument will incur floating point errors`
	`1221`	`+ # but no premature rounding`
`1220`	`1222`	`result = pd.to_datetime(1434743731.8770001, unit="s", cache=cache)`
`1221`	`1223`	`expected = pd.Timestamp("2015-06-19 19:55:31.877000192")`
`1222`	`1224`	`assert result == expected`
`@@ -1452,6 +1454,7 @@ def test_to_datetime_unit(self):`
`1452`	`1454`	`]`
`1453`	`1455`	`+ [NaT]`
`1454`	`1456`	`)`
	`1457`	`+ # GH20455 argument will incur floating point errors but no premature rounding`
`1455`	`1458`	`result = result.round("ms")`
`1456`	`1459`	`tm.assert_series_equal(result, expected)`
`1457`	`1460`