Skip to content

Commit 405037f

Browse files
committed
Update normalize value_counts test
1 parent 67ee980 commit 405037f

File tree

4 files changed

+2
-13
lines changed

4 files changed

+2
-13
lines changed

pandas/tests/extension/base/methods.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,13 @@ def test_value_counts(self, all_data, dropna):
3030

3131
def test_value_counts_with_normalize(self, data):
3232
data = data[:10].unique()
33+
values = np.array(data[~data.isna()])
3334

3435
result = (
3536
pd.Series(data, dtype=data.dtype).value_counts(normalize=True).sort_index()
3637
)
3738

38-
expected = pd.Series([1 / len(data)] * len(data), index=result.index)
39+
expected = pd.Series([1 / len(values)] * len(values), index=result.index)
3940
self.assert_series_equal(result, expected)
4041

4142
def test_count(self, data_missing):

pandas/tests/extension/test_boolean.py

-4
Original file line numberDiff line numberDiff line change
@@ -230,10 +230,6 @@ def test_searchsorted(self, data_for_sorting, as_series):
230230
def test_value_counts(self, all_data, dropna):
231231
return super().test_value_counts(all_data, dropna)
232232

233-
@pytest.mark.skip(reason="uses nullable integer")
234-
def test_value_counts_with_normalize(self, data):
235-
return super().test_value_counts_with_normalize(data)
236-
237233

238234
class TestCasting(base.BaseCastingTests):
239235
pass

pandas/tests/extension/test_integer.py

-4
Original file line numberDiff line numberDiff line change
@@ -224,10 +224,6 @@ def test_value_counts(self, all_data, dropna):
224224

225225
self.assert_series_equal(result, expected)
226226

227-
@pytest.mark.xfail(reason="not working with nan")
228-
def test_value_counts_with_normalize(self, data):
229-
super().test_value_counts_with_normalize(data)
230-
231227

232228
class TestCasting(base.BaseCastingTests):
233229
pass

pandas/tests/extension/test_sparse.py

-4
Original file line numberDiff line numberDiff line change
@@ -229,10 +229,6 @@ def test_fillna_frame(self, data_missing):
229229

230230

231231
class TestMethods(BaseSparseTests, base.BaseMethodsTests):
232-
@pytest.mark.xfail(reason="not working with nan")
233-
def test_value_counts_with_normalize(self):
234-
super().test_value_counts_with_normalize(data)
235-
236232
def test_combine_le(self, data_repeated):
237233
# We return a Series[SparseArray].__le__ returns a
238234
# Series[Sparse[bool]]

0 commit comments

Comments
 (0)