Skip to content

Commit 3e8c9d3

Browse files
committed
actually skip on windows
1 parent ad76d5b commit 3e8c9d3

File tree

1 file changed

+12
-27
lines changed

1 file changed

+12
-27
lines changed

pandas/tests/io/test_orc.py

+12-27
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,6 @@ def dirpath(datapath):
3333
return datapath("io", "data", "orc")
3434

3535

36-
# setup engines & skips
37-
@pytest.fixture(
38-
params=[
39-
pytest.param(
40-
"pyarrow",
41-
marks=pytest.mark.skipif(
42-
not _HAVE_PYARROW, reason="pyarrow is not installed"
43-
),
44-
)
45-
]
46-
)
47-
def engine(request):
48-
return request.param
49-
50-
5136
@pytest.fixture
5237
def pa():
5338
if not _HAVE_PYARROW:
@@ -76,7 +61,7 @@ def test_invalid_engine(dirpath):
7661
read_orc(inputfile, engine=engine, columns=["boolean1"])
7762

7863

79-
def test_orc_reader_empty(dirpath, engine):
64+
def test_orc_reader_empty(dirpath, pa):
8065
columns = [
8166
"boolean1",
8267
"byte1",
@@ -104,12 +89,12 @@ def test_orc_reader_empty(dirpath, engine):
10489
expected[colname] = pd.Series(dtype=dtype)
10590

10691
inputfile = os.path.join(dirpath, "TestOrcFile.emptyFile.orc")
107-
got = read_orc(inputfile, engine=engine, columns=columns)
92+
got = read_orc(inputfile, columns=columns)
10893

10994
tm.assert_equal(expected, got)
11095

11196

112-
def test_orc_reader_basic(dirpath, engine):
97+
def test_orc_reader_basic(dirpath, pa):
11398
data = {
11499
"boolean1": np.array([False, True], dtype="bool"),
115100
"byte1": np.array([1, 100], dtype="int8"),
@@ -124,12 +109,12 @@ def test_orc_reader_basic(dirpath, engine):
124109
expected = pd.DataFrame.from_dict(data)
125110

126111
inputfile = os.path.join(dirpath, "TestOrcFile.test1.orc")
127-
got = read_orc(inputfile, engine=engine, columns=data.keys())
112+
got = read_orc(inputfile, columns=data.keys())
128113

129114
tm.assert_equal(expected, got)
130115

131116

132-
def test_orc_reader_decimal(dirpath, engine):
117+
def test_orc_reader_decimal(dirpath, pa):
133118
from decimal import Decimal
134119

135120
# Only testing the first 10 rows of data
@@ -153,12 +138,12 @@ def test_orc_reader_decimal(dirpath, engine):
153138
expected = pd.DataFrame.from_dict(data)
154139

155140
inputfile = os.path.join(dirpath, "TestOrcFile.decimal.orc")
156-
got = read_orc(inputfile, engine=engine).iloc[:10]
141+
got = read_orc(inputfile).iloc[:10]
157142

158143
tm.assert_equal(expected, got)
159144

160145

161-
def test_orc_reader_date_low(dirpath, engine):
146+
def test_orc_reader_date_low(dirpath, pa):
162147
data = {
163148
"time": np.array(
164149
[
@@ -194,12 +179,12 @@ def test_orc_reader_date_low(dirpath, engine):
194179
expected = pd.DataFrame.from_dict(data)
195180

196181
inputfile = os.path.join(dirpath, "TestOrcFile.testDate1900.orc")
197-
got = read_orc(inputfile, engine=engine).iloc[:10]
182+
got = read_orc(inputfile).iloc[:10]
198183

199184
tm.assert_equal(expected, got)
200185

201186

202-
def test_orc_reader_date_high(dirpath, engine):
187+
def test_orc_reader_date_high(dirpath, pa):
203188
data = {
204189
"time": np.array(
205190
[
@@ -235,12 +220,12 @@ def test_orc_reader_date_high(dirpath, engine):
235220
expected = pd.DataFrame.from_dict(data)
236221

237222
inputfile = os.path.join(dirpath, "TestOrcFile.testDate2038.orc")
238-
got = read_orc(inputfile, engine=engine).iloc[:10]
223+
got = read_orc(inputfile).iloc[:10]
239224

240225
tm.assert_equal(expected, got)
241226

242227

243-
def test_orc_reader_snappy_compressed(dirpath, engine):
228+
def test_orc_reader_snappy_compressed(dirpath, pa):
244229
data = {
245230
"int1": np.array(
246231
[
@@ -276,6 +261,6 @@ def test_orc_reader_snappy_compressed(dirpath, engine):
276261
expected = pd.DataFrame.from_dict(data)
277262

278263
inputfile = os.path.join(dirpath, "TestOrcFile.testSnappy.orc")
279-
got = read_orc(inputfile, engine=engine).iloc[:10]
264+
got = read_orc(inputfile).iloc[:10]
280265

281266
tm.assert_equal(expected, got)

0 commit comments

Comments
 (0)