Skip to content

Commit 3e71336

Browse files
committed
REF: to_buffer -> render, unify func signature
1 parent 40b71f8 commit 3e71336

File tree

3 files changed

+21
-14
lines changed

3 files changed

+21
-14
lines changed

pandas/core/frame.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2614,7 +2614,7 @@ def to_html(
26142614
DataFrame.memory_usage: Memory usage of DataFrame columns."""
26152615
),
26162616
)
2617-
@doc(BaseInfo.to_buffer)
2617+
@doc(BaseInfo.render)
26182618
def info(
26192619
self,
26202620
verbose: Optional[bool] = None,
@@ -2627,7 +2627,7 @@ def info(
26272627
data=self,
26282628
memory_usage=memory_usage,
26292629
)
2630-
info.to_buffer(
2630+
info.render(
26312631
buf=buf,
26322632
max_cols=max_cols,
26332633
verbose=verbose,

pandas/core/series.py

+3-7
Original file line numberDiff line numberDiff line change
@@ -4640,7 +4640,7 @@ def replace(
46404640
Series.memory_usage: Memory usage of Series."""
46414641
),
46424642
)
4643-
@doc(BaseInfo.to_buffer)
4643+
@doc(BaseInfo.render)
46444644
def info(
46454645
self,
46464646
verbose: Optional[bool] = None,
@@ -4649,13 +4649,9 @@ def info(
46494649
memory_usage: Optional[Union[bool, str]] = None,
46504650
null_counts: bool = True,
46514651
) -> None:
4652-
if max_cols is not None:
4653-
raise ValueError(
4654-
"Argument `max_cols` can only be passed "
4655-
"in DataFrame.info, not Series.info"
4656-
)
4657-
return SeriesInfo(self, memory_usage).to_buffer(
4652+
return SeriesInfo(self, memory_usage).render(
46584653
buf=buf,
4654+
max_cols=max_cols,
46594655
verbose=verbose,
46604656
show_counts=null_counts,
46614657
)

pandas/io/formats/info.py

+16-5
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,14 @@ def size_qualifier(self) -> str:
160160
return size_qualifier
161161

162162
@abstractmethod
163-
def to_buffer():
163+
def render(
164+
self,
165+
*,
166+
buf: Optional[IO[str]],
167+
max_cols: Optional[int],
168+
verbose: Optional[bool],
169+
show_counts: Optional[bool],
170+
) -> None:
164171
"""
165172
Print a concise summary of a %(klass)s.
166173
@@ -266,7 +273,7 @@ def memory_usage_bytes(self) -> int:
266273
deep = False
267274
return self.data.memory_usage(index=True, deep=deep).sum()
268275

269-
def to_buffer(
276+
def render(
270277
self,
271278
*,
272279
buf: Optional[IO[str]],
@@ -296,15 +303,19 @@ def __init__(
296303
self.data: "Series" = data
297304
self.memory_usage = _initialize_memory_usage(memory_usage)
298305

299-
def to_buffer(
306+
def render(
300307
self,
301308
*,
302309
buf: Optional[IO[str]],
310+
max_cols: Optional[int],
303311
verbose: Optional[bool],
304312
show_counts: Optional[bool],
305313
) -> None:
306-
"""
307-
"""
314+
if max_cols is not None:
315+
raise ValueError(
316+
"Argument `max_cols` can only be passed "
317+
"in DataFrame.info, not Series.info"
318+
)
308319
printer = SeriesInfoPrinter(
309320
info=self,
310321
verbose=verbose,

0 commit comments

Comments
 (0)