CLN: Fix pylint undefined-loop-variable warnings (#49740)

* CLN: Fix pylint undefined-loop-variable warnings

* Fix undefined-loop-variable pylint warning

* CLN: Format props f-strings for clarity

Author: Leviob

pandas/io/formats/latex.py

@@ -160,8 +160,7 @@ def _get_strcols(self) -> list[list[str]]:
             def pad_empties(x):
                 for pad in reversed(x):
                     if pad:
-                        break
-                return [x[0]] + [i if i else " " * len(pad) for i in x[1:]]
+                        return [x[0]] + [i if i else " " * len(pad) for i in x[1:]]
 
             gen = (pad_empties(i) for i in out)
 

pandas/io/formats/printing.py

@@ -417,9 +417,9 @@ def best_len(values: list[str]) -> int:
             for max_items in reversed(range(1, len(value) + 1)):
                 pprinted_seq = _pprint_seq(value, max_seq_items=max_items)
                 if len(pprinted_seq) < max_space:
+                    head = [_pprint_seq(x, max_seq_items=max_items) for x in head]
+                    tail = [_pprint_seq(x, max_seq_items=max_items) for x in tail]
                     break
-            head = [_pprint_seq(x, max_seq_items=max_items) for x in head]
-            tail = [_pprint_seq(x, max_seq_items=max_items) for x in tail]
 
         summary = ""
         line = space2

pandas/io/formats/style.py

@@ -2304,8 +2304,8 @@ def set_sticky(
                             "selector": f"thead tr:nth-child({obj.nlevels+1}) th",
                             "props": props
                             + (
-                                f"top:{(i+1) * pixel_size}px; height:{pixel_size}px; "
-                                "z-index:2;"
+                                f"top:{(len(levels_)) * pixel_size}px; "
+                                f"height:{pixel_size}px; z-index:2;"
                             ),
                         }
                     )

pandas/tests/frame/test_iteration.py

@@ -159,4 +159,4 @@ def test_sequence_like_with_categorical(self):
             str(s)
 
         for c, col in df.items():
-            str(s)
+            str(col)

pyproject.toml

@@ -217,6 +217,7 @@ disable = [
   "too-many-public-methods",
   "too-many-return-statements",
   "too-many-statements",
+  "undefined-loop-variable",
   "unexpected-keyword-arg",
   "ungrouped-imports",
   "unsubscriptable-object",
@@ -276,7 +277,6 @@ disable = [
   "signature-differs",
   "super-init-not-called",
   "try-except-raise",
-  "undefined-loop-variable",
   "unnecessary-lambda",
   "unspecified-encoding",
   "unused-argument",