Skip to content

Commit 3b34368

Browse files
jbrockmendeljreback
authored andcommitted
CLN: Exception in _libs (#28967)
1 parent 3eca505 commit 3b34368

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

pandas/_libs/intervaltree.pxi.in

+2-2
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ cdef class IntervalTree(IntervalMixin):
158158

159159
# TODO: write get_indexer_intervals
160160
cdef:
161-
size_t old_len
161+
Py_ssize_t old_len
162162
Py_ssize_t i
163163
Int64Vector result
164164

@@ -179,7 +179,7 @@ cdef class IntervalTree(IntervalMixin):
179179
the given array of scalar targets. Non-unique positions are repeated.
180180
"""
181181
cdef:
182-
size_t old_len
182+
Py_ssize_t old_len
183183
Py_ssize_t i
184184
Int64Vector result, missing
185185

pandas/_libs/lib.pyx

+3-2
Original file line numberDiff line numberDiff line change
@@ -2072,7 +2072,7 @@ def maybe_convert_objects(ndarray[object] objects, bint try_float=0,
20722072
floats[i] = float(val)
20732073
complexes[i] = complex(val)
20742074
seen.float_ = 1
2075-
except Exception:
2075+
except (ValueError, TypeError):
20762076
seen.object_ = 1
20772077
break
20782078
else:
@@ -2352,7 +2352,8 @@ def to_object_array_tuples(rows: object):
23522352
row = rows[i]
23532353
for j in range(len(row)):
23542354
result[i, j] = row[j]
2355-
except Exception:
2355+
except TypeError:
2356+
# e.g. "Expected tuple, got list"
23562357
# upcast any subclasses to tuple
23572358
for i in range(n):
23582359
row = (rows[i],) if checknull(rows[i]) else tuple(rows[i])

pandas/_libs/tslibs/parsing.pyx

+1-1
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,7 @@ def try_parse_dates(object[:] values, parser=None,
581581
else:
582582
result[i] = parse_date(values[i])
583583
except Exception:
584-
# failed
584+
# Since parser is user-defined, we can't guess what it migh raise
585585
return values
586586
else:
587587
parse_date = parser

pandas/_libs/tslibs/timezones.pyx

+2-5
Original file line numberDiff line numberDiff line change
@@ -226,11 +226,8 @@ cdef object get_dst_info(object tz):
226226
if treat_tz_as_pytz(tz):
227227
trans = np.array(tz._utc_transition_times, dtype='M8[ns]')
228228
trans = trans.view('i8')
229-
try:
230-
if tz._utc_transition_times[0].year == 1:
231-
trans[0] = NPY_NAT + 1
232-
except Exception:
233-
pass
229+
if tz._utc_transition_times[0].year == 1:
230+
trans[0] = NPY_NAT + 1
234231
deltas = unbox_utcoffsets(tz._transition_info)
235232
typ = 'pytz'
236233

0 commit comments

Comments
 (0)