Skip to content

Commit 34f1f0a

Browse files
committed
DEPS: bump xlrd min version to 1.0.0
remove numpy warnings on np.diff in boolean arrays
1 parent e538182 commit 34f1f0a

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

ci/deps/travis-27.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ dependencies:
3535
- scipy
3636
- sqlalchemy=0.9.6
3737
- xarray=0.9.6
38-
- xlrd=0.9.2
38+
- xlrd=1.0.0
3939
- xlsxwriter=0.5.2
4040
- xlwt=0.7.5
4141
# universal

doc/source/whatsnew/v0.24.0.rst

+3-1
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ Backwards incompatible API changes
307307
Dependencies have increased minimum versions
308308
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
309309

310-
We have updated our minimum supported versions of dependencies (:issue:`21242`, `18742`).
310+
We have updated our minimum supported versions of dependencies (:issue:`21242`, :issue:`18742`, :issue:`23774`).
311311
If installed, we now require:
312312

313313
+-----------------+-----------------+----------+
@@ -331,6 +331,8 @@ If installed, we now require:
331331
+-----------------+-----------------+----------+
332332
| scipy | 0.18.1 | |
333333
+-----------------+-----------------+----------+
334+
| xlrd | 1.0.0 | |
335+
+-----------------+-----------------+----------+
334336

335337
Additionally we no longer depend on `feather-format` for feather based storage
336338
and replaced it with references to `pyarrow` (:issue:`21639` and :issue:`23053`).

pandas/_libs/algos_rank_helper.pxi.in

+1-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ def rank_1d_{{dtype}}(object in_arr, ties_method='average',
126126

127127
sorted_data = values.take(_as)
128128
sorted_mask = mask.take(_as)
129-
_indices = np.diff(sorted_mask).nonzero()[0]
129+
_indices = np.diff(sorted_mask.astype(int)).nonzero()[0]
130130
non_na_idx = _indices[0] if len(_indices) > 0 else -1
131131
argsorted = _as.astype('i8')
132132

0 commit comments

Comments
 (0)