Skip to content

Commit 34524ee

Browse files
CloseChoicejorisvandenbosschesimonjayhawkins
authored
REGR: NotImplementedError: Prefix not defined when slicing offset with loc (#47547)
Co-authored-by: Joris Van den Bossche <[email protected]> Co-authored-by: Simon Hawkins <[email protected]>
1 parent 606dd3c commit 34524ee

File tree

3 files changed

+50
-1
lines changed

3 files changed

+50
-1
lines changed

doc/source/whatsnew/v1.4.4.rst

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ Fixed regressions
2222
- Fixed regression in :meth:`DataFrame.loc` not updating the cache correctly after values were set (:issue:`47867`)
2323
- Fixed regression in :meth:`DataFrame.loc` not aligning index in some cases when setting a :class:`DataFrame` (:issue:`47578`)
2424
- Fixed regression in :meth:`DataFrame.loc` setting a length-1 array like value to a single value in the DataFrame (:issue:`46268`)
25+
- Fixed regression when slicing with :meth:`DataFrame.loc` with :class:`DateOffset`-index (:issue:`46671`)
2526
- Fixed regression in setting ``None`` or non-string value into a ``string``-dtype Series using a mask (:issue:`47628`)
2627
- Fixed regression using custom Index subclasses (for example, used in xarray) with :meth:`~DataFrame.reset_index` or :meth:`Index.insert` (:issue:`47071`)
2728
- Fixed regression in :meth:`DatetimeIndex.intersection` when the :class:`DatetimeIndex` has dates crossing daylight savings time (:issue:`46702`)

pandas/core/indexes/datetimelike.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,12 @@ def _parsed_string_to_bounds(self, reso: Resolution, parsed):
223223

224224
def _parse_with_reso(self, label: str):
225225
# overridden by TimedeltaIndex
226-
parsed, reso_str = parsing.parse_time_string(label, self.freq)
226+
try:
227+
if self.freq is None or hasattr(self.freq, "rule_code"):
228+
freq = self.freq
229+
except NotImplementedError:
230+
freq = getattr(self, "freqstr", getattr(self, "inferred_freq", None))
231+
parsed, reso_str = parsing.parse_time_string(label, freq)
227232
reso = Resolution.from_attrname(reso_str)
228233
return parsed, reso
229234

pandas/tests/frame/indexing/test_getitem.py

+43
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,14 @@
88
CategoricalDtype,
99
CategoricalIndex,
1010
DataFrame,
11+
DateOffset,
1112
DatetimeIndex,
1213
Index,
1314
MultiIndex,
1415
Series,
1516
Timestamp,
1617
concat,
18+
date_range,
1719
get_dummies,
1820
period_range,
1921
)
@@ -172,6 +174,47 @@ def test_getitem_iloc_two_dimensional_generator(self):
172174
expected = Series([5, 6], name="b", index=[1, 2])
173175
tm.assert_series_equal(result, expected)
174176

177+
def test_getitem_iloc_dateoffset_days(self):
178+
# GH 46671
179+
df = DataFrame(
180+
list(range(10)),
181+
index=date_range("01-01-2022", periods=10, freq=DateOffset(days=1)),
182+
)
183+
result = df.loc["2022-01-01":"2022-01-03"]
184+
expected = DataFrame(
185+
[0, 1, 2],
186+
index=DatetimeIndex(
187+
["2022-01-01", "2022-01-02", "2022-01-03"],
188+
dtype="datetime64[ns]",
189+
freq=DateOffset(days=1),
190+
),
191+
)
192+
tm.assert_frame_equal(result, expected)
193+
194+
df = DataFrame(
195+
list(range(10)),
196+
index=date_range(
197+
"01-01-2022", periods=10, freq=DateOffset(days=1, hours=2)
198+
),
199+
)
200+
result = df.loc["2022-01-01":"2022-01-03"]
201+
expected = DataFrame(
202+
[0, 1, 2],
203+
index=DatetimeIndex(
204+
["2022-01-01 00:00:00", "2022-01-02 02:00:00", "2022-01-03 04:00:00"],
205+
dtype="datetime64[ns]",
206+
freq=DateOffset(days=1, hours=2),
207+
),
208+
)
209+
tm.assert_frame_equal(result, expected)
210+
211+
df = DataFrame(
212+
list(range(10)),
213+
index=date_range("01-01-2022", periods=10, freq=DateOffset(minutes=3)),
214+
)
215+
result = df.loc["2022-01-01":"2022-01-03"]
216+
tm.assert_frame_equal(result, df)
217+
175218

176219
class TestGetitemCallable:
177220
def test_getitem_callable(self, float_frame):

0 commit comments

Comments
 (0)