BUG: is_float(e) and e.is_integer() added to IntBlock._can_hold_element

QuentinN42 · QuentinN42 · commit 3222d60ba424 · 2020-09-18T08:36:24.000+02:00
As @jbrockmendel said in #35376, you can replace an int by a float in an IntBlock only if the element is an integer.
diff --git a/pandas/core/internals/blocks.py b/pandas/core/internals/blocks.py
@@ -2067,7 +2067,7 @@ def _can_hold_element(self, element: Any) -> bool:
                 and not issubclass(tipo.type, (np.datetime64, np.timedelta64))
                 and self.dtype.itemsize >= tipo.itemsize
             )
-        return is_integer(element) or is_float(element)
+        return is_integer(element) or (is_float(element) and element.is_integer())
 
 
 class DatetimeLikeBlockMixin:

Original file line number	Diff line number	Diff line change
`@@ -2067,7 +2067,7 @@ def _can_hold_element(self, element: Any) -> bool:`
`2067`	`2067`	`and not issubclass(tipo.type, (np.datetime64, np.timedelta64))`
`2068`	`2068`	`and self.dtype.itemsize >= tipo.itemsize`
`2069`	`2069`	`)`
`2070`		`- return is_integer(element) or is_float(element)`
	`2070`	`+ return is_integer(element) or (is_float(element) and element.is_integer())`
`2071`	`2071`
`2072`	`2072`
`2073`	`2073`	`class DatetimeLikeBlockMixin:`