ENH #15972 implemented minor changes following jreback s comments

Author: Christoph Möhl

doc/source/whatsnew/v0.20.0.txt

@@ -514,7 +514,6 @@ Other Enhancements
 - ``parallel_coordinates()`` has gained a ``sort_labels`` keyword argument that sorts class labels and the colors assigned to them (:issue:`15908`)
 - Options added to allow one to turn on/off using ``bottleneck`` and ``numexpr``, see :ref:`here <basics.accelerate>` (:issue:`16157`)
 - ``DataFrame.style.bar()`` now accepts two more options to further customize the bar chart. Bar alignment is set with ``align='left'|'mid'|'zero'``, the default is "left", which is backward compatible; You can now pass a list of ``color=[color_negative, color_positive]``. (:issue:`14757`)
-- ``Crosstab`` has gained a ``margins_name`` parameter to define the name of the row / column that will contain the totals when margins is True(:issue:`15972`)
 
 .. _ISO 8601 duration: https://en.wikipedia.org/wiki/ISO_8601#Durations
 

doc/source/whatsnew/v0.21.0.txt

@@ -35,6 +35,7 @@ Other Enhancements
 - ``RangeIndex.append`` now returns a ``RangeIndex`` object when possible (:issue:`16212`)
 - :func:`to_pickle` has gained a protocol parameter (:issue:`16252`). By default, this parameter is set to `HIGHEST_PROTOCOL <https://docs.python.org/3/library/pickle.html#data-stream-format>`__
 - :func:`api.types.infer_dtype` now infers decimals. (:issue: `15690`)
+- ``Crosstab`` has gained a ``margins_name`` parameter to define the name of the row / column that will contain the totals when margins is True(:issue:`15972`)
 
 .. _whatsnew_0210.api_breaking:
 

pandas/core/reshape/pivot.py

@@ -416,7 +416,7 @@ def crosstab(index, columns, values=None, rownames=None, colnames=None,
         Name of the row / column that will contain the totals
         when margins is True.
 
-        .. versionadded:: 0.20.0
+        .. versionadded:: 0.21.0
 
     dropna : boolean, default True
         Do not include columns whose entries are all NaN
@@ -573,8 +573,6 @@ def _normalize(table, normalize, margins, margins_name='All'):
             index_margin = index_margin / index_margin.sum()
             index_margin.loc[margins_name] = 1
             table = concat([table, column_margin], axis=1)
-            print('index margin')
-            print(index_margin)
             table = table.append(index_margin)
 
             table = table.fillna(0)

pandas/tests/reshape/test_pivot.py

@@ -1072,6 +1072,7 @@ def test_crosstab_margins(self):
         tm.assert_series_equal(all_rows, exp_rows)
 
     def test_crosstab_margins_set_margin_name(self):
+        #GH 15972
         a = np.random.randint(0, 7, size=100)
         b = np.random.randint(0, 3, size=100)
         c = np.random.randint(0, 5, size=100)
@@ -1080,7 +1081,6 @@ def test_crosstab_margins_set_margin_name(self):
 
         result = crosstab(a, [b, c], rownames=['a'], colnames=('b', 'c'),
                           margins=True, margins_name='TOTAL')
-
         assert result.index.names == ('a',)
         assert result.columns.names == ['b', 'c']