BUG: The 'jobComplete' key may be present but False in the query results.

aaront · jreback · commit 3039533b3038 · 2015-03-06T17:58:31.000-05:00
Fixes an error when looking for 'totalRows' on a large dataset which is not finished in between two subsequent checks.

DOC: Added line to what's new for an bug in the BigQuery reader (GH8728)
diff --git a/doc/source/whatsnew/v0.16.0.txt b/doc/source/whatsnew/v0.16.0.txt
@@ -530,3 +530,5 @@ Bug Fixes
 
 
 - Fixed bug with reading CSV files from Amazon S3 on python 3 raising a TypeError (:issue:`9452`)
+
+- Bug in the Google BigQuery reader where the 'jobComplete' key may be present but False in the query results (:issue:`8728`)
diff --git a/pandas/io/gbq.py b/pandas/io/gbq.py
@@ -201,7 +201,7 @@ def run_query(self, query):
 
         job_reference = query_reply['jobReference']
 
-        while(not 'jobComplete' in query_reply):
+        while(not query_reply.get('jobComplete', False)):
             print('Job not yet complete...')
             query_reply = job_collection.getQueryResults(
                             projectId=job_reference['projectId'],

Original file line number	Diff line number	Diff line change
`@@ -530,3 +530,5 @@ Bug Fixes`
`530`	`530`
`531`	`531`
`532`	`532`	- Fixed bug with reading CSV files from Amazon S3 on python 3 raising a TypeError (:issue:`9452`)
	`533`	`+`
	`534`	+- Bug in the Google BigQuery reader where the 'jobComplete' key may be present but False in the query results (:issue:`8728`)