Skip to content

Commit 2f5c963

Browse files
committed
values_count fix
1 parent f8cf4b4 commit 2f5c963

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

pandas/tests/extension/base/methods.py

+9-3
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,18 @@ def test_value_counts(self, all_data, dropna):
3838

3939
def test_value_counts_with_normalize(self, data):
4040
# GH 33172
41-
data = data[:10].unique().remove_unused_categories()
41+
data = data[:10].unique()
4242
values = np.array(data[~data.isna()])
43+
ser = pd.Series(data, dtype=data.dtype)
4344

44-
result = pd.Series(data).value_counts(normalize=True).sort_index()
45+
result = ser.value_counts(normalize=True).sort_index()
46+
47+
if not isinstance(data, pd.Categorical):
48+
expected = pd.Series([1 / len(values)] * len(values), index=result.index)
49+
else:
50+
expected = pd.Series(0.0, index=result.index)
51+
expected[result > 0] = 1 / len(values)
4552

46-
expected = pd.Series([1 / len(values)] * len(values), index=result.index)
4753
self.assert_series_equal(result, expected)
4854

4955
def test_count(self, data_missing):

0 commit comments

Comments
 (0)