Skip to content

Commit 2f08999

Browse files
authored
CoW: Fix test that is failing with new arrow version (#54112)
1 parent d3870de commit 2f08999

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

pandas/compat/pyarrow.py

+2
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@
1313
pa_version_under9p0 = _palv < Version("9.0.0")
1414
pa_version_under10p0 = _palv < Version("10.0.0")
1515
pa_version_under11p0 = _palv < Version("11.0.0")
16+
pa_version_under12p0 = _palv < Version("12.0.0")
1617
pa_version_under13p0 = _palv < Version("13.0.0")
1718
except ImportError:
1819
pa_version_under7p0 = True
1920
pa_version_under8p0 = True
2021
pa_version_under9p0 = True
2122
pa_version_under10p0 = True
2223
pa_version_under11p0 = True
24+
pa_version_under12p0 = True
2325
pa_version_under13p0 = True

pandas/tests/copy_view/test_astype.py

+9-5
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import pytest
33

44
from pandas.compat import pa_version_under7p0
5+
from pandas.compat.pyarrow import pa_version_under12p0
56
import pandas.util._test_decorators as td
67

78
import pandas as pd
@@ -200,11 +201,14 @@ def test_astype_arrow_timestamp(using_copy_on_write):
200201
result = df.astype("timestamp[ns][pyarrow]")
201202
if using_copy_on_write:
202203
assert not result._mgr._has_no_reference(0)
203-
# TODO(CoW): arrow is not setting copy=False in the Series constructor
204-
# under the hood
205-
assert not np.shares_memory(
206-
get_array(df, "a"), get_array(result, "a")._pa_array
207-
)
204+
if pa_version_under12p0:
205+
assert not np.shares_memory(
206+
get_array(df, "a"), get_array(result, "a")._pa_array
207+
)
208+
else:
209+
assert np.shares_memory(
210+
get_array(df, "a"), get_array(result, "a")._pa_array
211+
)
208212

209213

210214
def test_convert_dtypes_infer_objects(using_copy_on_write):

0 commit comments

Comments
 (0)