Skip to content

Commit 2b5724b

Browse files
author
Guilherme Beltramini
committed
BUG: Reindex with columns and method
1 parent 72786cc commit 2b5724b

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

doc/source/whatsnew/v0.20.0.txt

+1
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,7 @@ Bug Fixes
285285
- Bug in ``DataFrame(..).apply(to_numeric)`` when values are of type decimal.Decimal. (:issue:`14827`)
286286
- Bug in ``describe()`` when passing a numpy array which does not contain the median to the ``percentiles`` keyword argument (:issue:`14908`)
287287
- Bug in ``DataFrame.sort_values()`` when sorting by multiple columns where one column is of type ``int64`` and contains ``NaT`` (:issue:`14922`)
288+
- Bug in ``DataFrame.reindex()`` when using ``columns`` and ``method`` (:issue:`14992`)
288289

289290

290291
- Bug in ``pd.read_msgpack()`` in which ``Series`` categoricals were being improperly processed (:issue:`14901`)

pandas/core/frame.py

+7-7
Original file line numberDiff line numberDiff line change
@@ -2710,8 +2710,8 @@ def _reindex_axes(self, axes, level, limit, tolerance, method, fill_value,
27102710

27112711
columns = axes['columns']
27122712
if columns is not None:
2713-
frame = frame._reindex_columns(columns, copy, level, fill_value,
2714-
limit, tolerance)
2713+
frame = frame._reindex_columns(columns, method, copy, level,
2714+
fill_value, limit, tolerance)
27152715

27162716
index = axes['index']
27172717
if index is not None:
@@ -2722,17 +2722,17 @@ def _reindex_axes(self, axes, level, limit, tolerance, method, fill_value,
27222722

27232723
def _reindex_index(self, new_index, method, copy, level, fill_value=NA,
27242724
limit=None, tolerance=None):
2725-
new_index, indexer = self.index.reindex(new_index, method, level,
2726-
limit=limit,
2725+
new_index, indexer = self.index.reindex(new_index, method=method,
2726+
level=level, limit=limit,
27272727
tolerance=tolerance)
27282728
return self._reindex_with_indexers({0: [new_index, indexer]},
27292729
copy=copy, fill_value=fill_value,
27302730
allow_dups=False)
27312731

2732-
def _reindex_columns(self, new_columns, copy, level, fill_value=NA,
2732+
def _reindex_columns(self, new_columns, method, copy, level, fill_value=NA,
27332733
limit=None, tolerance=None):
2734-
new_columns, indexer = self.columns.reindex(new_columns, level=level,
2735-
limit=limit,
2734+
new_columns, indexer = self.columns.reindex(new_columns, method=method,
2735+
level=level, limit=limit,
27362736
tolerance=tolerance)
27372737
return self._reindex_with_indexers({1: [new_columns, indexer]},
27382738
copy=copy, fill_value=fill_value,

pandas/sparse/frame.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -571,8 +571,8 @@ def _reindex_index(self, index, method, copy, level, fill_value=np.nan,
571571
new_series, index=index, columns=self.columns,
572572
default_fill_value=self._default_fill_value).__finalize__(self)
573573

574-
def _reindex_columns(self, columns, copy, level, fill_value, limit=None,
575-
takeable=False):
574+
def _reindex_columns(self, columns, method, copy, level, fill_value,
575+
limit=None, takeable=False):
576576
if level is not None:
577577
raise TypeError('Reindex by level not supported for sparse')
578578

0 commit comments

Comments
 (0)