Skip to content

Commit 2b53ea8

Browse files
authored
REF: remove always-True DataFrame._iset_item kwarg (#44587)
1 parent 4f91875 commit 2b53ea8

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

pandas/core/frame.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -3914,9 +3914,9 @@ def _set_item_mgr(self, key, value: ArrayLike) -> None:
39143914
if len(self):
39153915
self._check_setitem_copy()
39163916

3917-
def _iset_item(self, loc: int, value, inplace: bool = False) -> None:
3917+
def _iset_item(self, loc: int, value) -> None:
39183918
arraylike = self._sanitize_column(value)
3919-
self._iset_item_mgr(loc, arraylike, inplace=inplace)
3919+
self._iset_item_mgr(loc, arraylike, inplace=True)
39203920

39213921
# check if we are modifying a copy
39223922
# try to set first as we want an invalid

pandas/core/indexing.py

+6-10
Original file line numberDiff line numberDiff line change
@@ -1871,11 +1871,11 @@ def _setitem_single_column(self, loc: int, value, plane_indexer):
18711871
# The setitem happened inplace, so the DataFrame's values
18721872
# were modified inplace.
18731873
return
1874-
self.obj._iset_item(loc, ser, inplace=True)
1874+
self.obj._iset_item(loc, ser)
18751875
return
18761876

18771877
# reset the sliced object if unique
1878-
self.obj._iset_item(loc, ser, inplace=True)
1878+
self.obj._iset_item(loc, ser)
18791879

18801880
def _setitem_single_block(self, indexer, value, name: str):
18811881
"""
@@ -1892,19 +1892,15 @@ def _setitem_single_block(self, indexer, value, name: str):
18921892
# set using those methods to avoid block-splitting
18931893
# logic here
18941894
if (
1895-
len(indexer) > info_axis
1896-
and is_integer(indexer[info_axis])
1897-
and all(
1898-
com.is_null_slice(idx)
1899-
for i, idx in enumerate(indexer)
1900-
if i != info_axis
1901-
)
1895+
self.ndim == len(indexer) == 2
1896+
and is_integer(indexer[1])
1897+
and com.is_null_slice(indexer[0])
19021898
):
19031899
col = item_labels[indexer[info_axis]]
19041900
if len(item_labels.get_indexer_for([col])) == 1:
19051901
# e.g. test_loc_setitem_empty_append_expands_rows
19061902
loc = item_labels.get_loc(col)
1907-
self.obj._iset_item(loc, value, inplace=True)
1903+
self.obj._iset_item(loc, value)
19081904
return
19091905

19101906
indexer = maybe_convert_ix(*indexer) # e.g. test_setitem_frame_align

0 commit comments

Comments
 (0)