Merge pull request #4843 from jtratner/remove-rwproperty

CLN: replace rwproperty with regular property

Author: jtratner

doc/source/release.rst

@@ -287,6 +287,7 @@ See :ref:`Internal Refactoring<whatsnew_0130.refactoring>`
 - Refactor of Series arithmetic with time-like objects (datetime/timedelta/time
   etc.) into a separate, cleaned up wrapper class. (:issue:`4613`)
 - Complex compat for ``Series`` with ``ndarray``. (:issue:`4819`)
+- Removed unnecessary ``rwproperty`` from codebase in favor of builtin property. (:issue:`4843`)
 
 Experimental Features
 ~~~~~~~~~~~~~~~~~~~~~

pandas/core/internals.py

@@ -24,7 +24,6 @@
 from pandas.tslib import Timestamp
 from pandas import compat
 from pandas.compat import range, lrange, lmap, callable, map, zip
-from pandas.util import rwproperty
 
 
 class Block(PandasObject):
@@ -1450,22 +1449,22 @@ def shape(self):
     def itemsize(self):
         return self.dtype.itemsize
 
-    @rwproperty.getproperty
+    @property
     def fill_value(self):
         return self.values.fill_value
 
-    @rwproperty.setproperty
+    @fill_value.setter
     def fill_value(self, v):
         # we may need to upcast our fill to match our dtype
         if issubclass(self.dtype.type, np.floating):
             v = float(v)
         self.values.fill_value = v
 
-    @rwproperty.getproperty
+    @property
     def sp_values(self):
         return self.values.sp_values
 
-    @rwproperty.setproperty
+    @sp_values.setter
     def sp_values(self, v):
         # reset the sparse values
         self.values = SparseArray(

pandas/core/series.py

@@ -37,7 +37,6 @@
 from pandas import compat
 from pandas.util.terminal import get_terminal_size
 from pandas.compat import zip, lzip, u, OrderedDict
-from pandas.util import rwproperty
 
 import pandas.core.array as pa
 
@@ -797,19 +796,19 @@ def __contains__(self, key):
         return key in self.index
 
     # complex
-    @rwproperty.getproperty
+    @property
     def real(self):
         return self.values.real
 
-    @rwproperty.setproperty
+    @real.setter
     def real(self, v):
         self.values.real = v
 
-    @rwproperty.getproperty
+    @property
     def imag(self):
         return self.values.imag
 
-    @rwproperty.setproperty
+    @imag.setter
     def imag(self, v):
         self.values.imag = v
 

pandas/sparse/series.py

@@ -21,7 +21,6 @@
 import pandas.index as _index
 
 from pandas import compat
-from pandas.util import rwproperty
 
 from pandas.sparse.array import (make_sparse, _sparse_array_op, SparseArray)
 from pandas._sparse import BlockIndex, IntIndex
@@ -213,11 +212,11 @@ def get_values(self):
     def block(self):
         return self._data._block
 
-    @rwproperty.getproperty
+    @property
     def fill_value(self):
         return self.block.fill_value
 
-    @rwproperty.setproperty
+    @fill_value.setter
     def fill_value(self, v):
         self.block.fill_value = v