FIX PeriodConverter unicode parsing

Author: jorisvandenbossche

pandas/tseries/converter.py

@@ -109,7 +109,7 @@ class PeriodConverter(dates.DateConverter):
     def convert(values, units, axis):
         if not hasattr(axis, 'freq'):
             raise TypeError('Axis must have `freq` set to convert to Periods')
-        valid_types = (str, datetime, Period, pydt.date, pydt.time)
+        valid_types = (compat.string_types, datetime, Period, pydt.date, pydt.time)
         if (isinstance(values, valid_types) or com.is_integer(values) or
                 com.is_float(values)):
             return get_datevalue(values, axis.freq)
@@ -127,7 +127,7 @@ def convert(values, units, axis):
 def get_datevalue(date, freq):
     if isinstance(date, Period):
         return date.asfreq(freq).ordinal
-    elif isinstance(date, (str, datetime, pydt.date, pydt.time)):
+    elif isinstance(date, (compat.string_types, datetime, pydt.date, pydt.time)):
         return Period(date, freq).ordinal
     elif (com.is_integer(date) or com.is_float(date) or
           (isinstance(date, (np.ndarray, Index)) and (date.size == 1))):

pandas/tseries/tests/test_converter.py

@@ -115,8 +115,6 @@ class Axis(object):
         self.axis.freq = 'D'
 
     def test_convert_accepts_unicode(self):
-        # FIXME
-        raise nose.SkipTest("PeriodConverter does not yet handle unicode")
         r1 = self.pc.convert("2012-1-1", None, self.axis)
         r2 = self.pc.convert(u("2012-1-1"), None, self.axis)
         self.assert_equal(r1, r2, "PeriodConverter.convert should accept unicode")