Revise attribute/method consistency check to skip known inconsistencies

Author: Matt Hagy

pandas/tests/test_groupby.py

@@ -5986,13 +5986,44 @@ def test_groupby_whitelist(self):
             # 'nlargest', 'nsmallest',
         ])
 
+        # TODO: Fix these inconsistencies between attribute and method names
+        inconsistently_named = frozenset([
+            'tshift',
+            'any',
+            'dtypes',
+            'idxmax',
+            'all',
+            'fillna',
+            'rank',
+            'quantile',
+            'cummax',
+            'take',
+            'corr',
+            'cummin',
+            'diff',
+            'plot',
+            'pct_change',
+            'skew',
+            'hist',
+            'bfill',
+            'cov',
+            'boxplot',
+            'describe',
+            'corrwith',
+            'idxmin',
+            'ffill',
+            'mad',
+            'dtype',
+            'unique'
+        ])
+
         for obj, whitelist in zip((df, s), (df_whitelist, s_whitelist)):
             gb = obj.groupby(df.letters)
             self.assertEqual(whitelist, gb._apply_whitelist)
             for m in whitelist:
                 f = getattr(type(gb), m)
-                # TODO: Fix inconsistencies between attribute and method names
-                # self.assertEqual(f.__name__, m)
+                if m not in inconsistently_named:
+                    self.assertEqual(f.__name__, m)
 
     AGG_FUNCTIONS = ['sum', 'prod', 'min', 'max', 'median', 'mean', 'skew',
                      'mad', 'std', 'var', 'sem']
@@ -6095,12 +6126,6 @@ def test_tab_completion(self):
              'ffill', 'bfill', 'pad', 'backfill', 'rolling', 'expanding'])
         self.assertEqual(results, expected)
 
-    def test_groupby_function_rename(self):
-        grp = self.mframe.groupby(level='second')
-        for name in ['sum', 'prod', 'min', 'max', 'first', 'last']:
-            f = getattr(grp, name)
-            self.assertEqual(f.__name__, name)
-
     def test_lexsort_indexer(self):
         keys = [[nan] * 5 + list(range(100)) + [nan] * 5]
         # orders=True, na_position='last'