Brock feedback

Author: WillAyd

pandas/_libs/lib.pyx

@@ -834,8 +834,7 @@ cpdef ndarray[object] ensure_string_array(
             if isinstance(val, bytes):
                 # GH#49658 discussion of desired behavior here
                 result[i] = val.decode()
-            elif isinstance(val, np.ndarray):
-                # TODO(wayd): is_float_object actually returns true for this...
+            elif util.is_array(val):
                 result[i] = str(val.tolist())
             elif not util.is_float_object(val):
                 # f"{val}" is faster than str(val)

pandas/io/formats/format.py

@@ -1467,27 +1467,6 @@ def _format_strings(self) -> list[str]:
         return fmt_values
 
 
-class _NullFormatter(_GenericArrayFormatter):
-    def _format_strings(self) -> list[str]:
-        fmt_values = [str(x) for x in self.values]
-        return fmt_values
-
-
-class _ListFormatter(_GenericArrayFormatter):
-    def _format_strings(self) -> list[str]:
-        # TODO(wayd): This doesn't seem right - where should missing values
-        # be handled
-        fmt_values = []
-        for x in self.values:
-            pyval = x.as_py()
-            if pyval:
-                fmt_values.append(pyval)
-            else:
-                fmt_values.append("")
-
-        return fmt_values
-
-
 class _Datetime64Formatter(_GenericArrayFormatter):
     values: DatetimeArray